fix(loader): ignore applet min-height message while applet visible - #504
fix(loader): ignore applet min-height message while applet visible#504MyLeeJiEun wants to merge 1 commit into
Conversation
1. Track the opened applet widget via PluginItem::appletOpened signal 2. Ignore MSG_SET_APPLET_MIN_HEIGHT while applet is showing to avoid panel height jumps on plugin changes 3. Flush the pending message on applet Show, dropping stale values set while hidden Log: Quick panel ignores min-height updates while displayed PMS: BUG-375629 fix(loader): 快捷面板展示时不响应最小高度消息 1. 通过 PluginItem::appletOpened 信号跟踪已打开的 applet 控件 2. 快捷面板展示期间不响应 MSG_SET_APPLET_MIN_HEIGHT,避免插件增删导致面板高度跳变 3. 在 applet Show 时投递暂存消息,隐藏期间设置的旧值直接作废 Log: 快捷面板展示期间不响应最小高度消息 PMS: BUG-375629
There was a problem hiding this comment.
Sorry @MyLeeJiEun, you've used your own review budget of 250,000 diff characters for the last 7 days.
You can request another review in 4 days and 6 hours by commenting @sourcery-ai review. Upgrade to get a review now.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: MyLeeJiEun The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @MyLeeJiEun. Thanks for your PR. I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Reviewer's GuideThe loader now tracks the active applet widget and suppresses minimum-height messages while it is visible, using event-filter-based Show handling to apply only the latest deferred update and prevent panel height jumps during plugin changes. Sequence diagram for deferred applet minimum-height updatessequenceDiagram
participant PluginItem
participant WidgetPlugin
participant Applet as AppletWidget
participant Interface as PluginsItemInterfaceV2
PluginItem->>WidgetPlugin: appletOpened(applet)
WidgetPlugin->>Applet: installEventFilter(this)
Interface->>WidgetPlugin: eventMessage(message)
WidgetPlugin->>WidgetPlugin: onDockEventMessageArrived(message)
alt MSG_SET_APPLET_MIN_HEIGHT and applet is visible
WidgetPlugin->>WidgetPlugin: Store latest pending message
else Other message or applet is hidden
WidgetPlugin->>Interface: message(message)
end
Applet-->>WidgetPlugin: QEvent::Show
WidgetPlugin->>WidgetPlugin: eventFilter(watched, event)
WidgetPlugin->>Interface: message(pending message)
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Log: Quick panel ignores min-height updates while displayed
PMS: BUG-375629
fix(loader): 快捷面板展示时不响应最小高度消息
Log: 快捷面板展示期间不响应最小高度消息
PMS: BUG-375629
Summary by Sourcery
Keep quick-panel minimum-height updates from affecting the panel while its applet is visible.
Bug Fixes:
Enhancements: