chore: update pkg-config include path for tray loader - #496
Open
18202781743 wants to merge 1 commit into
Open
Conversation
1. Change the includedir variable in dde-tray-loader.pc.in from `@CMAKE_INSTALL_FULL_INCLUDEDIR@/dde-tray-loader` to `@CMAKE_INSTALL_FULL_INCLUDEDIR@/dde-dock` 2. This corrects the actual installation directory where the tray plugin development headers are placed 3. Ensures pkg-config consumers can successfully locate and include the correct header files Influence: 1. Verify that `pkg-config --cflags dde-tray-loader` returns the updated include path pointing to `dde-dock` 2. Test building a sample program that uses the tray plugin headers via pkg-config 3. Ensure that consumer packages depending on this pc file can compile without header resolution errors chore: 更新托盘加载器的 pkg-config 包含路径 1. 将 dde-tray-loader.pc.in 中的 includedir 变量 从 `@CMAKE_INSTALL_FULL_INCLUDEDIR@/dde-tray-loader` 改为 `@CMAKE_INSTALL_FULL_INCLUDEDIR@/dde-dock` 2. 修正了托盘插件开发头文件实际安装目录的配置 3. 确保使用 pkg-config 的消费者能够正确定位并引用正确的头文件 Influence: 1. 验证 `pkg-config --cflags dde-tray-loader` 返回的包含路径指向 `dde- dock` 2. 测试通过 pkg-config 使用托盘插件头文件构建示例程序的过程 3. 确保依赖此 pc 文件的消费者包能够正常编译,无头文件解析错误
18202781743
requested review from
BLumia,
mhduiy,
robertkill,
wjyrich and
yixinshark
August 21, 2026 03:18
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the pkg-config template for dde-tray-loader so that the advertised include directory matches the actual dde-dock header installation path, ensuring consumers can find the tray plugin development headers correctly. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
BLumia
approved these changes
Aug 21, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, BLumia The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from
@CMAKE_INSTALL_FULL_INCLUDEDIR@/dde-tray-loaderto@CMAKE_INSTALL_FULL_INCLUDEDIR@/dde-dockdevelopment headers are placed
correct header files
Influence:
pkg-config --cflags dde-tray-loaderreturns the updatedinclude path pointing to
dde-dockpkg-config
without header resolution errors
chore: 更新托盘加载器的 pkg-config 包含路径
从
@CMAKE_INSTALL_FULL_INCLUDEDIR@/dde-tray-loader改为@CMAKE_INSTALL_FULL_INCLUDEDIR@/dde-dockInfluence:
pkg-config --cflags dde-tray-loader返回的包含路径指向dde- dockSummary by Sourcery
Bug Fixes: