Skip to content

chore: update pkg-config include path for tray loader - #496

Open
18202781743 wants to merge 1 commit into
linuxdeepin:masterfrom
18202781743:master
Open

chore: update pkg-config include path for tray loader#496
18202781743 wants to merge 1 commit into
linuxdeepin:masterfrom
18202781743:master

Conversation

@18202781743

@18202781743 18202781743 commented Aug 21, 2026

Copy link
Copy Markdown
Contributor
  1. Change the includedir variable in dde-tray-loader.pc.in
    from @CMAKE_INSTALL_FULL_INCLUDEDIR@/dde-tray-loader to
    @CMAKE_INSTALL_FULL_INCLUDEDIR@/dde-dock
  2. This corrects the actual installation directory where the tray plugin
    development headers are placed
  3. Ensures pkg-config consumers can successfully locate and include the
    correct header files

Influence:

  1. Verify that pkg-config --cflags dde-tray-loader returns the updated
    include path pointing to dde-dock
  2. Test building a sample program that uses the tray plugin headers via
    pkg-config
  3. Ensure that consumer packages depending on this pc file can compile
    without header resolution errors

chore: 更新托盘加载器的 pkg-config 包含路径

  1. 将 dde-tray-loader.pc.in 中的 includedir 变量
    @CMAKE_INSTALL_FULL_INCLUDEDIR@/dde-tray-loader 改为
    @CMAKE_INSTALL_FULL_INCLUDEDIR@/dde-dock
  2. 修正了托盘插件开发头文件实际安装目录的配置
  3. 确保使用 pkg-config 的消费者能够正确定位并引用正确的头文件

Influence:

  1. 验证 pkg-config --cflags dde-tray-loader 返回的包含路径指向 dde- dock
  2. 测试通过 pkg-config 使用托盘插件头文件构建示例程序的过程
  3. 确保依赖此 pc 文件的消费者包能够正常编译,无头文件解析错误

Summary by Sourcery

Bug Fixes:

  • Correct the tray loader pkg-config include path so consumers can locate the installed development headers.

1. Change the includedir variable in dde-tray-loader.pc.in
from `@CMAKE_INSTALL_FULL_INCLUDEDIR@/dde-tray-loader` to
`@CMAKE_INSTALL_FULL_INCLUDEDIR@/dde-dock`
2. This corrects the actual installation directory where the tray plugin
development headers are placed
3. Ensures pkg-config consumers can successfully locate and include the
correct header files

Influence:
1. Verify that `pkg-config --cflags dde-tray-loader` returns the updated
include path pointing to `dde-dock`
2. Test building a sample program that uses the tray plugin headers via
pkg-config
3. Ensure that consumer packages depending on this pc file can compile
without header resolution errors

chore: 更新托盘加载器的 pkg-config 包含路径

1. 将 dde-tray-loader.pc.in 中的 includedir 变量
从 `@CMAKE_INSTALL_FULL_INCLUDEDIR@/dde-tray-loader` 改为
`@CMAKE_INSTALL_FULL_INCLUDEDIR@/dde-dock`
2. 修正了托盘插件开发头文件实际安装目录的配置
3. 确保使用 pkg-config 的消费者能够正确定位并引用正确的头文件

Influence:
1. 验证 `pkg-config --cflags dde-tray-loader` 返回的包含路径指向 `dde-
dock`
2. 测试通过 pkg-config 使用托盘插件头文件构建示例程序的过程
3. 确保依赖此 pc 文件的消费者包能够正常编译,无头文件解析错误
@sourcery-ai

sourcery-ai Bot commented Aug 21, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the pkg-config template for dde-tray-loader so that the advertised include directory matches the actual dde-dock header installation path, ensuring consumers can find the tray plugin development headers correctly.

File-Level Changes

Change Details Files
Correct pkg-config includedir for dde-tray-loader to point to the dde-dock headers directory used at install time.
  • Update the includedir definition to use @CMAKE_INSTALL_FULL_INCLUDEDIR@/dde-dock instead of @CMAKE_INSTALL_FULL_INCLUDEDIR@/dde-tray-loader so pkg-config --cflags reports the real header path
  • Align the pkg-config metadata with the actual installation layout of tray plugin development headers to avoid header resolution errors for downstream builds
dde-tray-loader.pc.in

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, BLumia

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants