TPT-4656: Support NodeBalancer type and backend connectivity - #735
Open
zliang-akamai wants to merge 1 commit into
Open
TPT-4656: Support NodeBalancer type and backend connectivity#735zliang-akamai wants to merge 1 commit into
zliang-akamai wants to merge 1 commit into
Conversation
Expose type and backend_connectivity on NodeBalancer, document create kwargs, and cover IPv6/VPC backends in unit and integration tests.
zliang-akamai
requested review from
psnoch-akamai and
yec-akamai
and removed request for
a team
August 28, 2026 23:46
Contributor
There was a problem hiding this comment.
Pull request overview
Adds SDK support for NodeBalancer type and backend_connectivity by exposing them as read-only model properties, documenting the new create-time parameters, and extending tests/fixtures to cover IPv6 backend address formats and the new response fields.
Changes:
- Expose
NodeBalancer.typeandNodeBalancer.backend_connectivityas read-only properties and ensure they are omitted from PUT payloads. - Document
type,backend_connectivity,vpcs, andconfigson NodeBalancer creation, and update node address documentation to include IPv6 bracketed formats. - Expand unit/integration test coverage and fixtures to validate the new fields and IPv6 node address forwarding.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/unit/objects/nodebalancers_test.py | Adds unit tests for IPv6 node creation, config rebuild with IPv6 nodes, and NodeBalancer type/backend_connectivity behavior. |
| test/unit/linode_client_test.py | Adds unit tests ensuring create() forwards type, backend_connectivity, configs node addresses, and vpcs. |
| test/integration/models/nodebalancer/test_nodebalancer.py | Updates integration create test to pass and assert type/backend_connectivity. |
| test/fixtures/nodebalancers.json | Extends list fixture data with type and backend_connectivity. |
| test/fixtures/nodebalancers_123456.json | Extends single NodeBalancer fixture with type and backend_connectivity. |
| test/fixtures/linode_instances_123_nodebalancers.json | Extends Linode->NodeBalancers fixture with type and backend_connectivity. |
| linode_api4/objects/nodebalancer.py | Updates node address docstring and adds NodeBalancer type/backend_connectivity properties. |
| linode_api4/groups/nodebalancer.py | Documents type, backend_connectivity, vpcs, and configs kwargs on NodeBalancer create. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
108
to
111
| client_udp_sess_throttle=5, | ||
| type="premium", | ||
| backend_connectivity="ipv6", | ||
| ) |
Comment on lines
+165
to
+168
| :param address: The address where this backend can be reached. This may | ||
| be a private IPv4 address, a public IPv6 address in | ||
| ``[IPv6]:port`` format, or a VPC address. The address | ||
| type must match this NodeBalancer's ``backend_connectivity``. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Add SDK support for NodeBalancer
typeandbackend_connectivity.✔️ How to Test
Unit Testing
Integration Testing