Skip to content

Using official naming conventions; use only login-action for OIDC #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zliang-akamai wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Using official naming conventions; use only login-action for OIDC #921

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,18 +47,13 @@ jobs:
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v4

- name: OIDC connections
id: docker_oidc
uses: docker/oidc-action@v1
with:
connection-id: ${{ vars.DOCKER_OIDC_CONNECTION_ID }}
expires-in: 1800

- name: Login to Docker Hub
uses: docker/login-action@v4
with:
username: ${{ vars.DOCKER_ORGANIZATION_NAME }}
password: ${{ steps.docker_oidc.outputs.token }}
username: ${{ vars.DOCKERHUB_ORGANIZATION }}
env:
DOCKERHUB_OIDC_CONNECTIONID: ${{ vars.DOCKERHUB_OIDC_CONNECTIONID }}
DOCKERHUB_OIDC_EXPIREIN: 1800

# This is necessary as we want to ensure that version tags
# are properly formatted before passing them into the
Expand Down