Skip to content

Add success feedback for karma operations - #329

Open
konard wants to merge 3 commits into
mainfrom
issue-59-083cf96e
Open

Add success feedback for karma operations#329
konard wants to merge 3 commits into
mainfrom
issue-59-083cf96e

Conversation

@konard

@konard konard commented Sep 13, 2025

Copy link
Copy Markdown
Member

🎯 Issue Summary

Fixes #59 - Users requested feedback when karma operations (+ or -) succeed.

🔍 Problem

Previously, when users scored with + or -, the bot would silently delete their message without providing clear feedback about whether the operation succeeded. Users were left wondering if their vote was counted.

✅ Solution Implemented

1. Enhanced Karma Change Messages

  • Added ✅ success indicators to all karma change notifications
  • Messages now clearly state "Карма успешно изменена" (Karma successfully changed)

2. Vote Registration Feedback

  • When collective votes don't immediately change karma (need 2+ votes for positive, 3+ for negative), users now get feedback:
    • "✅ Ваш голос за [User] засчитан! Голосов: 1/2. До изменения кармы осталось: 1."
  • Shows current vote count and remaining votes needed

3. Complete Coverage

  • Collective votes: Feedback for both partial votes and completed karma changes
  • Personal transfers: Clear success messages for direct karma transfers (+5, -3, etc.)
  • All scenarios: Every successful operation now provides user feedback

📝 Technical Changes

Modified Files

  • python/modules/commands_builder.py: Added new feedback message builders
  • python/modules/commands.py: Enhanced apply_karma method to always send feedback

New Methods

  • build_vote_registered(): Feedback for partial collective votes
  • Enhanced build_karma_change(): Added success indicators

🧪 Testing

  • Created test scripts in experiments/ folder demonstrating the functionality
  • Verified all karma operation scenarios provide appropriate feedback
  • Ensured Russian language consistency with existing bot messages

📈 User Experience Impact

  • Before: Users unsure if their votes counted (silent deletion)
  • After: Clear, immediate feedback for all karma operations
  • Reduces user confusion and improves engagement confidence

🤖 Generated with Claude Code

Adding CLAUDE.md with task information for AI processing.
This file will be removed when the task is complete.

Issue: #59
@konard konard self-assigned this Sep 13, 2025
- Enhanced karma change messages with ✅ success indicator
- Added feedback for vote registration when karma hasn't changed yet
- Users now receive clear confirmation when their + or - votes are processed
- Improved user experience with explicit success messages in Russian
- Added test scripts demonstrating the new feedback functionality

Fixes #59 - Bot now provides feedback that karma operations were successful

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@konard konard changed the title [WIP] Feedback Add success feedback for karma operations Sep 13, 2025
@konard
konard marked this pull request as ready for review September 13, 2025 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feedback

1 participant