Repository navigation
Raise SQL identifier limit to 253 to match K8s name limit - #258
Merged
Merged
Conversation
Generated pipeline/view/job identifiers routinely exceed Calcite's default identifier length of 128, producing cryptic "Length of identifier ... must be less than or equal to 128 characters" parse errors. These identifiers ultimately become Kubernetes resource names, whose ceiling is the DNS-subdomain limit of 253 characters. - Add shared IdentifierUtils.MAX_IDENTIFIER_LENGTH (253) and apply it to both parser paths: IdentifierUtils (quoted bare-string parsing used by graph resolution, CLI !resolve/!graph, and PipelineGraphBuilder) and HoptimatorDriver (DDL/query parser). - Fix K8sUtils.checkK8sName, which incorrectly capped names at the 63-char DNS-label limit; that limit applies to label values and label-typed resources (e.g. Services), not to these DNS-subdomain resource names. Now capped at 253 via the shared constant. - Add unit tests for both parser paths and the name guard (accept at 253, reject at 254), and a real-k8s integration test asserting the apiserver's 422 "must be no more than 253 characters" response. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Code Coverage
|
jogrogan
enabled auto-merge (squash)
October 8, 2026 22:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated pipeline/view/job identifiers can exceed Calcite's default identifier length of 128, producing "Length of identifier ... must be less than or equal to 128 characters" parse errors. These identifiers ultimately become Kubernetes resource names, whose ceiling is the DNS-subdomain limit of 253 characters.
Realistically we should be able to support larger identifiers but we'd need to add some sort of deterministic hashing logic for the k8s CR names which can make observability difficult, so we'll punt this for now.