Conversation
Carry explicit staging source intent for CIN/text imports so named tables are published instead of falling back to the empty custom table. Preserve Android-compatible custom-first backup mapping semantics, validate SQL table identifiers, and add exact tricode plus lifecycle regression coverage.
…-cin-import # Conflicts: # docs/#242_ISSUE.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
customtablecustommappings first, requested-table fallback, destination-table metadataRoot cause
The staging database always contains a
customtable. For a named CIN import such astricode, the parser correctly populatedstaging.tricode, but publication selected the emptystaging.customtable first and rejected the staging database. The released behavior therefore produced zero live rows despite successfully parsing the source file.Android imports CIN/text data directly into the explicitly requested table. This change preserves that observable contract while retaining the separate
custom-first mapping behavior used for Android-compatible.limedb/ZIP backups.Verification
Evidence completed for executable head
a4c7b5869c678c5adedff98493e70b7382f28fd7:Current head
0559afb621840e2405f735ae099b634703058e89is not ready:git diff --check origin/master...0559afb6currently fails on three trailing-whitespace lines in the pinned CIN fixturesim.disablewithrow["disable"] as Int? ?? 0. Add a TEXT-valued fixture and decode throughDatabaseValueand the establishedparseBoolFlagcontractgit diff --check, and independent review on the corrected exact headScope
This PR intentionally excludes the unrelated
pinyin.ziptest-fixture resolver defect found while auditing the historical 6.1.38 full suite. That infrastructure work will remain separate from Issue #242.Refs #242