Skip to content

test(cli): normalise rich-panel output before asserting on BadParameter text #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ligon merged 1 commit into from
Sep 9, 2026
Merged

test(cli): normalise rich-panel output before asserting on BadParameter text #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion tests/test_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import json
import os
import re
import subprocess
from pathlib import Path
from types import SimpleNamespace
Expand All @@ -16,6 +17,24 @@
from sucoder import cli
from sucoder.config import BranchPrefixes, Config, MirrorSettings


_ANSI_ESCAPE = re.compile(r"\x1b\[[0-9;?]*[ -/]*[@-~]")
_BOX_DRAWING = re.compile(r"[\u2500-\u257f]")


def _plain_output(result) -> str:
"""CLI output with styling, panel borders, and line wraps removed.

typer renders ``BadParameter`` through a rich panel and forces terminal
mode when ``GITHUB_ACTIONS`` (or ``FORCE_COLOR``) is set, so under CI the
message is coloured and wrapped at 80 columns even though no terminal is
attached. A substring assertion on the raw output therefore depends on
the console width; assert against this normalised text instead.
"""
text = _ANSI_ESCAPE.sub("", result.output)
text = _BOX_DRAWING.sub(" ", text)
return " ".join(text.split())

try:
from click.shell_completion import CompletionItem as ClickCompletionItem
except (ImportError, AttributeError): # pragma: no cover - defensive
Expand Down Expand Up @@ -414,7 +433,7 @@ def test_harness_and_legacy_agent_are_mutually_exclusive(tmp_path, monkeypatch):
)

assert result.exit_code != 0
assert "either --harness or the legacy --agent" in result.output
assert "either --harness or the legacy --agent" in _plain_output(result)


def test_skills_list_reports_accessible_paths(tmp_path, monkeypatch):
Expand Down
Loading