You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If it is a core feature, I have added thorough tests.
Testing
uv run pytest tests/integration/inference_registry/ -q
Summary by CodeRabbit
Tests
Expanded integration coverage for inference provider startup, including provider configuration, model discovery, allow-list filtering, and provider-specific model handling.
Added checks for discovery failures and registry behavior when setup cannot complete. This improves confidence that provider initialization and model selection behave consistently across supported integrations.
No actionable comments were generated in the recent review.
Walkthrough
This pull request adds integration tests for inference provider registry startup. The tests cover skipped discovery, provider-specific model catalogs, filtering, and OpenAI and Bedrock discovery failures.
Changes
Inference registry startup coverage
Layer / File(s)
Summary
Startup test setup tests/integration/inference_registry/*
Shared fixtures write and load inference configuration, reset the ProviderRegistry singleton around tests, and support checks for skipped discovery and empty provider configuration.
The change adds startup tests without changing runtime behavior. The tests and scanner still need a working CI environment.
Pre-merge checks: 7
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title "LCORE-4710: Add inference registry startup integration tests" matches the changeset. The PR adds integration tests under tests/integration/inference_registry/ covering registry startup with…
Docstring Coverage
Docstring coverage is 93.33% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentati…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Performance And Algorithmic Complexity
PASS. The pull request only adds integration-test modules, fixtures, and mocks. It does not change production handlers, Kubernetes or database operations, caches, watchers, or API endpoints. The added…
Security And Secret Handling
PASSED. The pull request adds only test files under tests/integration/inference_registry/. The credential-like values in _helpers.py:52-65,99 are explicit dummy fixtures such as test-key, `test-…
Full details: Title check
Explanation
The title "LCORE-4710: Add inference registry startup integration tests" matches the changeset. The PR adds integration tests under tests/integration/inference_registry/ covering registry startup with discovery skipped, allow-list filtering, provider-specific discovery for OpenAI, Bedrock, Vertex and vLLM, and startup failure on discovery errors. The title is concise, specific, and includes the ticket key without noise.
Full details: Docstring Coverage
Explanation
Docstring coverage is 93.33% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 15 functions across 4 files.
Full details: Performance And Algorithmic Complexity
Explanation
PASS. The pull request only adds integration-test modules, fixtures, and mocks. It does not change production handlers, Kubernetes or database operations, caches, watchers, or API endpoints. The added loops and list conversions process small in-memory test fixtures; no O(n^2) algorithm, N+1 calls, unbounded growth, or missing pagination is introduced.
Full details: Security And Secret Handling
Explanation
PASSED. The pull request adds only test files under tests/integration/inference_registry/. The credential-like values in _helpers.py:52-65,99 are explicit dummy fixtures such as test-key, test-bearer-token, unused, and xyzzy; no real secrets are present. The changes add no logging, API endpoints, response handling, command execution, SQL, or Kubernetes Secret resources. No plaintext secret leakage, missing endpoint authorization, injection flaw, or missing OwnerReference is introduced.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Simplify code
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
Recent review details
Context from checks skipped due to timeout: 25
GitHub Check: Red Hat Konflux / lightspeed-core-0-8-enterprise-contract / lightspeed-stack-0-8
GitHub Check: Red Hat Konflux / lightspeed-stack-0-8-e2e-tests / lightspeed-stack-0-8
GitHub Check: integration_tests (3.12)
GitHub Check: integration_tests (3.13)
GitHub Check: list_outdated_dependencies
GitHub Check: mypy
GitHub Check: integration_tests (3.14)
GitHub Check: radon
GitHub Check: Pylinter
GitHub Check: check_dependencies
GitHub Check: Red Hat Konflux / rag-content-0-8-e2e-tests / lightspeed-stack-0-8
##[group]Installed versions
Version 3.8 was not found in the local cache
(node:2287) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
##[error]The version '3.8' with architecture 'x64' was not found for Ubuntu 26.04.
##[group]Installed versions
Version 3.8 was not found in the local cache
(node:2287) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
##[error]The version '3.8' with architecture 'x64' was not found for Ubuntu 26.04.
Source excerpt: **Required**: Use pytest for all unit and integration tests **Forbidden**: Do not use unittest - pytest is the standard for this project Source excerpt: **Coverage**: Unit tests require 60% coverage, integration 10%
Source excerpt: **Required**: Use pytest for all unit and integration tests Source excerpt: **Forbidden**: Do not use unittest - pytest is the standard for this project Source excerpt: **Coverage**: Unit tests require 60% coverage, integrat...
Learnt from: CR
Repo: lightspeed-core/lightspeed-stack PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-10-31T11:32:30.158Z
Learning: Applies to tests/{unit,integration}/** : Source excerpt:
# Lightspeed Core Stack Development Guide
## Testing Framework
### Testing Framework Requirements
- **Required**: Use pytest for all unit and integration tests
- **Forbidden**: Do not use unittest - pytest is the standard for this project
Learnt from: CR
Repo: lightspeed-core/lightspeed-stack PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-10-31T11:32:13.138Z
Learning: Applies to tests/{unit,integration}/** : Source excerpt:
# Lightspeed Core Stack Development Guide
## Testing Framework
### Testing Framework Requirements
- **Forbidden**: Do not use unittest - pytest is the standard for this project
Learnt from: CR
Repo: lightspeed-core/lightspeed-stack PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-10-31T11:32:13.138Z
Learning: Applies to tests/{unit,integration}/** : Source excerpt:
# Lightspeed Core Stack Development Guide
## Testing Framework
### Testing Framework Requirements
- **Required**: Use pytest for all unit and integration tests
Test-only PR adding 4 new integration test files for inference registry startup. Zero production code changes, no protected paths, no security-sensitive files, no dependency changes. All files are brand new with no churn or contention history. Composite rounds to 2 (moderate) driven primarily by line count.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
fullsend-ai-review
Bot
added
ready-for-merge
Description
Adds integration tests for inference provider registry startup: skip-discovery wiring for every registered provider type, allow-list keep/drop, provider-specific discovery paths (OpenAI/vLLM/Bedrock/Vertex/sentence-transformers), and discovery failure abort behavior. Foreign APIs are mocked.
Type of change
pyproject.toml+uv.lock]requirements.*.txtfor Konflux]Tools used to create PR
Related Tickets & Documents
Checklist before requesting a review
Testing
uv run pytest tests/integration/inference_registry/ -qSummary by CodeRabbit