Repository navigation
LCORE-5254: (fix) Run retro agent manually only on a /fs-retro comment - #3112
Conversation
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Configure retro trigger .fullsend/config.yaml |
The trigger requires a comment_added transition, the /fs-retro command, and a human actor. |
Estimated code review effort: 2 (Simple) | ~5 minutes
Change: Bug fix
Possibly related PRs
- lightspeed-core/lightspeed-stack#3087: Moves the retro agent into
agents[]and configures the/fs-retrocondition inharness/retro.yaml. - lightspeed-core/lightspeed-stack#3074: Addresses the same behavior by requiring a human
/fs-retrocomment.
Suggested reviewers: tisnik, gwennie
Merge Risk: 
28657
-
The configured trigger matches the intended manual retro workflow, with no actionable merge-blocking risk established.
Pre-merge checks: 
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title names a Jira-style key (LCORE-5254), a fix type, and the main change: the retro agent runs manually only on a /fs-retro comment. The raw summary confirms the retro agent in .fullsend/config.… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Performance And Algorithmic Complexity PASS. The pull request changes only .fullsend/config.yamland adds a bounded CEL trigger predicate for the retro agent. It adds no loops, API or database calls, list operations, parsers, caches, wat…Security And Secret Handling PASSED. The pull request changes only .fullsend/config.yaml. It adds a static CEL trigger that requires a/fs-retrocommand and a human actor. The diff adds no secrets, tokens, API endpoints, comm…Full details: Title check
-
Explanation
The title names a Jira-style key (LCORE-5254), a fix type, and the main change: the retro agent runs manually only on a /fs-retro comment. The raw summary confirms the retro agent in .fullsend/config.yaml now runs only when a human adds a comment whose command is /fs-retro. The title matches the primary change and is specific, so it passes.
Full details: Performance And Algorithmic Complexity
-
Explanation
PASS. The pull request changes only
.fullsend/config.yamland adds a bounded CEL trigger predicate for the retro agent. It adds no loops, API or database calls, list operations, parsers, caches, watchers, or other unbounded work. No meaningful performance regression is introduced.
Full details: Security And Secret Handling
-
Explanation
PASSED. The pull request changes only
.fullsend/config.yaml. It adds a static CEL trigger that requires a/fs-retrocommand and a human actor. The diff adds no secrets, tokens, API endpoints, command execution, path handling, response/logging changes, or Kubernetes Secret resources. The referenced harness uses the same trigger condition.
-
Finishing Touches
-
Generate unit tests (beta)
-
- Create a new PR
Simplify code
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
2865790 to
d2735c9
Compare
Intended behavior: when a pull request is closed or merged, the retro agent should do nothing; it should run only when a human posts a comment whose first line is the /fs-retro slash command. Signed-off-by: Anik Bhattacharjee <anbhatta@redhat.com>
d2735c9 to
443aaa0
Compare
|
🤖 Finished Retro · ✅ Success · Started 9:27 AM UTC · Completed 9:39 AM UTC Commit: Runtime: pi · Model: opus → claude-opus-4-6 · Effort: high · Cost: $3.25 |
Retro: PR #3112 — Fix retro agent triggerTimelineThis PR is the third in a chain of 3 PRs over 5 days, all by anik120 under LCORE-5254, to correctly restrict the retro agent to manual
On the merge of PR #3087 (run 41285662022), the retro dispatch failed with ObservationsReview agent did not dispatch on any of the 3 PRs. On PR #3112's open event (run 41461132666), the Route step logged "No stage matched — skipping dispatch." The root cause is unclear — anik120 has merge permissions, so the permission check should pass. This meant the only automated review came from CodeRabbit. Retro still dispatched on this merge. Despite PR #3112 adding Evidence for existing issues
Review qualityCodeRabbit's review on PR #3087 was the standout: it correctly identified the functional issue (harness trigger not gating built-in routing) and provided the exact fix that became PR #3112. The human reviewer approved all 3 PRs with "LGTM" without engaging with CodeRabbit's Major finding. Had that finding been addressed during PR #3087 review, PR #3112 would not have been necessary. No proposals are filed because the root causes are well-tracked by existing platform issues. |
Description
Intended behavior: when a pull request is closed or merged, the retro agent
should do nothing; it should run only when a human posts a comment whose
first line is the /fs-retro slash command.
Type of change
pyproject.toml+uv.lock]requirements.*.txtfor Konflux]Tools used to create PR
Identify any AI code assistants used in this PR (for transparency and review context)
Related Tickets & Documents
Checklist before requesting a review
Testing
Summary by CodeRabbit
/fs-retro. Other comments no longer trigger it.