Skip to content

RSPEED-3105: mark sentence-transformers and vllm as supported in providers.md - #3106

Merged
tisnik merged 1 commit into
mainfrom
agent/3105-update-providers-md-supported-status
Nov 2, 2026
Merged

tisnik merged 1 commit into
mainfrom
agent/3105-update-providers-md-supported-status

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown
Contributor

Summary

Update the Inference Providers table in docs/devel_doc/providers.md to reflect the actual provider registry after PR #3034 merged.

Changes

  • sentence-transformers: Changed 'Supported in LCS' from ❌ to ✅ — SentenceTransformersInferenceProvider is registered in PROVIDER_CLASSES
  • vllm: Added new row with ✅ — VllmInferenceProvider is registered in PROVIDER_CLASSES but had no row in the main table (the existing Red Hat sub-table entries use the openai provider type)

Validation

Both providers confirmed present in src/providers/inference/registry.py.


Closes #3105

Post-script verification

  • Branch is not main/master (agent/3105-update-providers-md-supported-status)
  • Secret scan passed (gitleaks — f687827ca58992a0ad7f8e5c18a92f984db2939c..HEAD)
  • PR body secret scan passed (gitleaks — no-git)
  • Final PR description secret scan passed (gitleaks — no-git)

…iders.md

Update the Inference Providers table in docs/devel_doc/providers.md to
reflect the actual provider registry:

- sentence-transformers: change Supported in LCS from \u274c to \u2705
  (SentenceTransformersInferenceProvider was added in PR #3034)
- vllm: add new row with \u2705 (VllmInferenceProvider was registered
  in the same commit as sentence-transformers)

Both providers are present in PROVIDER_CLASSES in
src/providers/inference/registry.py but the documentation was not
updated when they were merged.

Closes #3105
@fullsend-ai-coder fullsend-ai-coder Bot added the ready-for-review Triggers review agent dispatch label Nov 2, 2026
@coderabbitai

coderabbitai Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@fullsend-ai-review

fullsend-ai-review Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 11:41 AM UTC · Completed 11:50 AM UTC

Commit: ec19edf · View workflow run →

Runtime: pi · Model: opus → claude-opus-4-6 · Effort: high · Cost: $2.09

@fullsend-ai-review

Copy link
Copy Markdown

Looks good to me


Risk assessment missing — risk assessment is enabled but no score was
produced. A human reviewer must evaluate this PR.


Labels: Documentation-only PR updating the providers table.

@fullsend-ai-review fullsend-ai-review Bot added requires-manual-review Review requires human judgment documentation Improvements or additions to documentation labels Nov 2, 2026
@tisnik
tisnik requested a review from asimurka November 2, 2026 12:41

@tisnik tisnik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tisnik
tisnik merged commit 4ef25a2 into main Nov 2, 2026
130 of 131 checks passed
@fullsend-ai-retro

fullsend-ai-retro Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 2:51 PM UTC · Completed 2:58 PM UTC

Commit: ec19edf · View workflow run →

Runtime: pi · Model: opus → claude-opus-4-6 · Effort: high · Cost: $2.03

@fullsend-ai-retro

Copy link
Copy Markdown

PR #3106 was a documentation-only fix updating docs/devel_doc/providers.md to mark sentence-transformers and vllm as supported. It originated from a retro agent finding on PR #3034 (issue #3105). The full end-to-end workflow was smooth: retro created the issue → triage verified and enhanced it (adding the vllm finding) → code agent produced a minimal 3-line fix → review agent approved correctly → two humans approved → merged. Total agent cost: $4.20 ($1.15 triage + $0.96 code + $2.09 review).

Key observations:

  1. Risk assessment missing on this PR — The review agent noted "Risk assessment missing — no score was produced" and applied requires-manual-review. This is additional evidence for Risk-assessment review sub-agent silently omits its comment on ~15% of PRs (e.g. #7385) fullsend-ai/fullsend#7387 (risk-assessment sub-agent silently omits its comment on ~15% of PRs).

  2. Review cost for trivial docs change — $2.09 and a cross-repo-contracts sub-agent for a 3-line markdown table edit. Additional evidence for Skip irrelevant review dimensions for docs-only PRs to reduce token cost fullsend-ai/agents#373 (skip irrelevant review dimensions for docs-only PRs).

  3. Root cause: review finding ignored on PR LCORE-4709: Implemented sentence transformers provider #3034 — The review agent correctly flagged stale providers.md as a HIGH severity finding and requested changes on PR LCORE-4709: Implemented sentence transformers provider #3034. Humans merged without addressing it. The entire follow-up cycle (issue Update providers.md to mark sentence-transformers as supported after PR #3034 #3105 → PR RSPEED-3105: mark sentence-transformers and vllm as supported in providers.md #3106) exists only because that finding was not acted on. A deterministic CI check would prevent this class of drift.

Autonomy readiness: Both human reviewers approved without substantive comments. Per methodology, silent approvals are inconclusive — they cannot be used as evidence for autonomy changes.

Agents repo: fullsend-ai/agents@v0.51.0 (discovered from review run 41438325677).

Proposals filed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ready-for-review Triggers review agent dispatch requires-manual-review Review requires human judgment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update providers.md to mark sentence-transformers as supported after PR #3034

2 participants