Skip to content

LCORE-4922: Updated dependencies - #3097

Merged
tisnik merged 1 commit into
lightspeed-core:mainfrom
tisnik:lcore-4922-updated-dependencies-4
Nov 2, 2026
Merged

tisnik merged 1 commit into
lightspeed-core:mainfrom
tisnik:lcore-4922-updated-dependencies-4

Conversation

@tisnik

@tisnik tisnik commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Description

LCORE-4922: Updated dependencies

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library [pyproject.toml + uv.lock]
  • Bump-up dependent library [requirements.*.txt for Konflux]
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

  • Assisted-by: N/A
  • Generated by: N/A

Related Tickets & Documents

  • Related Issue #LCORE-4922

@coderabbitai

coderabbitai Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters: 1
  • uv.lock is excluded by !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@fullsend-ai-review

fullsend-ai-review Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 7:35 AM UTC · Completed 7:45 AM UTC

Commit: 18ca55b · View workflow run →

Runtime: pi · Model: opus → claude-opus-4-6 · Effort: high · Cost: $2.77

@fullsend-ai-review fullsend-ai-review Bot added the risk/moderate PR risk: moderate label Nov 2, 2026
@fullsend-ai-review

Copy link
Copy Markdown

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Pure lockfile dependency bump (uv.lock only, 1 file, 806 lines). Tier 1 average 1.63: change-size scores high due to line count in auto-generated file, but all other signals minimal — no protected paths, no security-sensitive files, no CI changes, non-bot returning author. Tier 2 average 2.57: uv.lock is a high-churn hotspot with many authors, but no reverts or negative sentiment. Weighted composite 1.99 rounds to 2. A routine lockfile refresh with low functional risk.

@fullsend-ai-review

Copy link
Copy Markdown

Looks good to me

@fullsend-ai-review fullsend-ai-review Bot added the ready-for-merge All reviewers approved — ready to merge label Nov 2, 2026
@tisnik
tisnik merged commit 0e5800f into lightspeed-core:main Nov 2, 2026
88 checks passed
@fullsend-ai-retro

fullsend-ai-retro Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 10:21 AM UTC · Completed 10:28 AM UTC

Commit: 18ca55b · View workflow run →

Runtime: pi · Model: opus → claude-opus-4-6 · Effort: high · Cost: $2.80

@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #3097 — LCORE-4922: Updated dependencies

Timeline: Human author tisnik opened a lockfile-only PR (uv.lock, +404/−402, ~29 packages updated) at 07:34 UTC. The review agent (opus, $2.77) approved at 07:45 UTC with "Looks good to me" and a risk assessment of moderate (2/5). No human reviewed the PR. It merged at 10:17 UTC.

Key observation: The lockfile update included three major version bumps — filelock 3.x→4.x, huggingface-hub 1.x→2.x (which also switched its HTTP dependency from httpx to httpx2), and importlib-metadata 8.x→10.x — none of which the review agent flagged. These are exactly the kind of transitions that could introduce breaking behavioral changes, even as transitive dependencies.

No new proposals filed — existing issues cover both findings:

  1. Major version detection gap: fullsend-ai/agents#448 ("Review orchestrator triage should escalate scope for lockfile patches with major version transitions") and fullsend-ai/agents#449 ("Review agent scope classification should detect major version bumps in lockfile patches and escalate from trivial") directly address this. This PR provides concrete new evidence: three major version transitions (including huggingface-hub 1→2 with a dependency swap) passed through review without mention.

  2. Review cost on mechanical changes: fullsend-ai/agents#513 ("short-circuit to lightweight mode for mechanical dependency bump"), fullsend-ai/agents#497 ("downgrade sub-agent models based on scope classification"), and fullsend-ai/agents#1431 ("reduce sub-agent dispatch breadth for mechanical/value-only changes") cover the $2.77 opus cost for a single auto-generated file. Related platform-level issues include fullsend-ai/fullsend#8383 and fullsend-ai/fullsend#8095.

Autonomy assessment: Inconclusive — no human left review findings, so the agent-vs-human delta cannot be meaningfully computed for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge All reviewers approved — ready to merge risk/moderate PR risk: moderate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant