Skip to content

Configure REVIEW_SKIP_AUTHORS to skip reviews on Konflux bot PRs #3101

Open

Description

@fullsend-ai-retro

What happened

PR #3090 is a Konflux bot PR updating SHA256 digests in 4 .tekton/ YAML files. The fullsend review agent (run 41148166317) used Opus at high effort, dispatched 5 sub-agents (correctness, security, style-conventions, intent-coherence, risk-assessment), and correctly approved with zero findings — costing $2.99 over ~14 minutes. This pattern repeated on PRs #3089 ($2.39) and #3092 ($2.06) in the same batch. Konflux PRs arrive in batches of ~4/week (one per release branch), all containing only SHA256 digest bumps with zero code impact.

What could go better

The fullsend review agent already supports a REVIEW_SKIP_AUTHORS env var (implemented in fullsend-ai/agents PR #592, merged 2026-08-05). When configured, the pre-review.sh script checks the PR author against a comma-separated list and exits early on match — no agent launched, no tokens spent. This repo has not opted in: there is no env override setting REVIEW_SKIP_AUTHORS in the .fullsend/ config. The mechanism is proven and tested (11 test cases in pre-review-test.sh). Confidence is high that configuring it would eliminate the review cost for all Konflux bot PRs on this repo.

Proposed change

Add the Konflux bot author to the REVIEW_SKIP_AUTHORS configuration for this repo's fullsend setup. The exact author login is app/red-hat-konflux-kflux-prd-rh02. The env var should be set in the repo's .fullsend/ configuration (likely .fullsend/env/review.env or equivalent per-repo env override mechanism). If the repo's .fullsend/ config doesn't support per-agent env files, set it in whichever location the harness reads env vars from — consult the fullsend documentation or the env/review.env file in the agents repo for the expected format. Note: the exact login format must match what pre-review.sh fetches via gh pr view --json author; verify the match format before deploying.

Validation criteria

After configuration, the next Konflux bot PR from app/red-hat-konflux-kflux-prd-rh02 should show the review stage completing instantly with a skip notice in the workflow logs (no agent launched, $0 cost). Verify over 2-3 Konflux PR batches (~1 week) that no review agent runs and no review approval is posted by fullsend-ai-review[bot] on these PRs. Expected savings: ~$10/week at current volume.

Related issues checked

Searched: REVIEW_SKIP_AUTHORS konflux bot skip review; review cost bot automated dependency digest bump Tekton
Considered: fullsend-ai/agents#368, fullsend-ai/agents#257, fullsend-ai/fullsend#1358, fullsend-ai/fullsend#7583, fullsend-ai/fullsend#8911
fullsend-ai/agents#368 (closed/completed) implemented the REVIEW_SKIP_AUTHORS mechanism — this proposal is about adopting it in this specific repo's config, not re-implementing it. The remaining open issues (#257, #1358, #7583, #8911) propose automatic/platform-level detection of bot authors, which would make per-repo config unnecessary — but those are still open and this repo can benefit from the opt-in mechanism today.


Generated by retro agent from #3090

Activity

  1. fullsend-ai-triage commented on Nov 2, 2026

    @fullsend-ai-triage

    🤖 Finished Triage · ✅ Success · Started 9:20 AM UTC · Completed 9:24 AM UTC

    Commit: 27550f7 · View workflow run →

    Runtime: pi · Model: opus → claude-opus-4-6 · Effort: high · Cost: $1.18

  2. fullsend-ai-triage commented on Nov 2, 2026

    @fullsend-ai-triage

    Severity: low — cost optimization with no functional impact.

    Recommended fix: Add REVIEW_SKIP_AUTHORS=app/red-hat-konflux-kflux-prd-rh02 to the .fullsend/ per-repo configuration. The repo currently has no per-agent env overrides, so the appropriate file or config block will need to be created following the fullsend layered config reference. Before deploying, confirm the author login format matches the output of gh pr view --json author on a Konflux PR.

    Proposed validation:

    # After the config change, on the next Konflux bot PR:
    # 1. Check workflow logs for the review stage — expect an instant skip notice
    # 2. Confirm no fullsend-ai-review[bot] approval comment appears
    # 3. Monitor over 2–3 batches (~1 week) to confirm consistent behavior
    

    Labels: Issue concerns Konflux bot PR handling and is an enhancement to CI tooling configuration.


    Next steps:

    • /fs-code — agent creates a PR to implement this issue
    • /fs-code <your instruction> — agent implements with your specific guidance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions