Remove remittanceInformation from the Quote response schema - #757
Closed
ls-bolt[bot] wants to merge 1 commit into
Closed
Remove remittanceInformation from the Quote response schema#757ls-bolt[bot] wants to merge 1 commit into
ls-bolt[bot] wants to merge 1 commit into
Conversation
remittanceInformation is an input on QuoteRequest only; the Quote response no longer echoes it back.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Contributor
Author
|
@greptileai review |
Contributor
✱ Stainless preview builds for gridThis PR will update the cli feat(api): remove remittanceInformation from quote model openapi python typescript ⏳ grid-kotlin studio⏳ grid-python studio⏳ grid-php studio⏳ grid-cli studio⏳ These are partial results; builds are still running. This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push. |
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
Contributor
Greptile SummaryThis PR aligns the documented Quote response with the API’s actual response shape.
Confidence Score: 5/5The PR appears safe to merge because the response-only schema correction is consistently reflected across the source and generated specifications. The removed field has no in-repository Quote response consumers, remains available on the request schemas that accept it, and is removed consistently from both generated bundles.
|
| Filename | Overview |
|---|---|
| openapi/components/schemas/quotes/Quote.yaml | Removes the response-only remittanceInformation property while leaving the Quote request contract unchanged. |
| openapi.yaml | Regenerated root bundle accurately reflects the source schema removal. |
| mintlify/openapi.yaml | Regenerated Mintlify bundle remains synchronized with the root OpenAPI bundle. |
Reviews (1): Last reviewed commit: "Remove remittanceInformation from the Qu..." | Re-trigger Greptile
shreyav
added a commit
that referenced
this pull request
Jul 28, 2026
## Summary `remittanceInformation` is an input field only — callers set it on `POST /quotes` and it travels with the payment on the rail. The `Quote` response schema was also echoing it back, which documented a field the API does not return. This removes it from `Quote` (the response) and leaves it in place on `QuoteRequest`. ## Changes: 3 files - `openapi/components/schemas/quotes/Quote.yaml` — drop the `remittanceInformation` property - `openapi.yaml`, `mintlify/openapi.yaml` — regenerated bundles (`make build`) No version bump: the field was never a documented, relied-upon part of the response, and no `servers.url` path change is involved. ## Test plan - `make build` — bundles regenerate cleanly - `make lint` — 0 errors (630 pre-existing warnings/infos, unchanged by this diff) - Confirmed no other reference to the field on the response side: request-side usages in the CLI (`cli/src/commands/quotes.ts`, `cli/src/commands/transfers.ts`), the visualizer code generator, the docs snippets, `TransferOutRequest`, and `RealtimeFundingTransactionSource` are all untouched Requested by @shreyav Original PR: #757
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
remittanceInformationis an input field only — callers set it onPOST /quotesand it travels with the payment on the rail. TheQuoteresponse schema was also echoing it back, which documented a field the API does not return.This removes it from
Quote(the response) and leaves it in place onQuoteRequest.Changes: 3 files
openapi/components/schemas/quotes/Quote.yaml— drop theremittanceInformationpropertyopenapi.yaml,mintlify/openapi.yaml— regenerated bundles (make build)No version bump: the field was never a documented, relied-upon part of the response, and no
servers.urlpath change is involved.Test plan
make build— bundles regenerate cleanlymake lint— 0 errors (630 pre-existing warnings/infos, unchanged by this diff)cli/src/commands/quotes.ts,cli/src/commands/transfers.ts), the visualizer code generator, the docs snippets,TransferOutRequest, andRealtimeFundingTransactionSourceare all untouchedRequested by @shreyav