Skip to content

chore: Sync account schemas #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lightspark-copybara wants to merge 1 commit into
base: main
Choose a base branch
from
+25 −3
Open

chore: Sync account schemas #738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion mintlify/openapi.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 8 additions & 1 deletion openapi.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion openapi/components/schemas/common/GtqAccountInfoBase.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ properties:
- SAVINGS
bankName:
type: string
description: The name of the beneficiary's bank
description: The name of the bank
minLength: 1
maxLength: 255
example:
Expand Down
8 changes: 8 additions & 0 deletions openapi/components/schemas/common/PhpAccountInfoBase.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,13 @@ properties:
type: string
enum:
- PHP_ACCOUNT
rail:
type: string
description: The payment rail to route the payout over, for currencies that support
more than one (e.g. NEFT or RTGS for INR).
example: NEFT
minLength: 1
maxLength: 32
Comment on lines +11 to +17

@greptile-apps greptile-apps Bot Jul 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 INR rail references inside a PHP schema

The new rail field's description and example both reference Indian payment infrastructure (NEFT/RTGS for INR) inside a Philippine Peso (PHP) account schema. The description reads "e.g. NEFT or RTGS for INR" and the example sets rail: NEFT — NEFT is the National Electronic Funds Transfer system used in India, not the Philippines. For PHP accounts the relevant rails would be PESONet or InstaPay. Any consumer reading this schema to understand what values to send will be misled into submitting an Indian rail identifier for a Philippine account.

Prompt To Fix With AI 
This is a comment left during a code review.
Path: openapi/components/schemas/common/PhpAccountInfoBase.yaml
Line: 11-17

Comment:
**INR rail references inside a PHP schema**

The new `rail` field's description and example both reference Indian payment infrastructure (NEFT/RTGS for INR) inside a Philippine Peso (PHP) account schema. The description reads "e.g. NEFT or RTGS for INR" and the example sets `rail: NEFT` — NEFT is the National Electronic Funds Transfer system used in India, not the Philippines. For PHP accounts the relevant rails would be PESONet or InstaPay. Any consumer reading this schema to understand what values to send will be misled into submitting an Indian rail identifier for a Philippine account.

How can I resolve this? If you propose a fix, please make it concise.

bankName:
type: string
description: Name of the beneficiary's bank
Expand All @@ -23,5 +30,6 @@ properties:
pattern: ^[0-9]{8,16}$
example:
accountType: PHP_ACCOUNT
rail: NEFT
bankName: BDO Unibank
accountNumber: '001234567890'
Loading