Repository navigation
[v0.20.x-branch] Backport #10520: routerrpc: FailureDetail enums for invoice/AMP validation failures - #11238
Merged
ziggie1984 merged 1 commit intoSep 23, 2026
Conversation
(cherry picked from commit 05eed5c)
ziggie1984
force-pushed
the
backport-10520-to-v0.20.x-branch
branch
from
September 23, 2026 11:59
d2fc1b8 to
e5046bd
Compare
ziggie1984
commented
Sep 23, 2026
ziggie1984
left a comment
Collaborator
Author
There was a problem hiding this comment.
LGTM needed for #11224
ziggie1984
merged commit Sep 23, 2026
ff5bbde
into
lightningnetwork:v0.20.x-branch
31 of 35 checks passed
🟠 PR Severity: HIGH
🟠 High (4 files)
🟢 Low (1 file)
AnalysisAll substantive changes live under To override, add a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #10520
Change Description
Extend
routerrpc.FailureDetailwith explicit values for invoice and AMPvalidation outcomes and map the corresponding invoice resolution results in
SubscribeHtlcEvents.This prevents HTLC event subscriptions from terminating with an unknown
failure-resolution error for these outcomes and gives subscribers stable,
specific failure details instead of
UNKNOWN.The original release-note entry is moved from the 0.21.0 notes to the active
0.20.5 notes, and the protobuf artifacts are regenerated with the current
20.x toolchain.
Verification
make rpc-checkgo test ./lnrpc/...