Skip to content

[v0.20.x-branch] Backport #10520: routerrpc: FailureDetail enums for invoice/AMP validation failures - #11238

Merged
ziggie1984 merged 1 commit into
lightningnetwork:v0.20.x-branchfrom
ziggie1984:backport-10520-to-v0.20.x-branch
Sep 23, 2026
Merged

ziggie1984 merged 1 commit into
lightningnetwork:v0.20.x-branchfrom
ziggie1984:backport-10520-to-v0.20.x-branch

Conversation

@ziggie1984

Copy link
Copy Markdown
Collaborator

Backport of #10520


Change Description

Extend routerrpc.FailureDetail with explicit values for invoice and AMP
validation outcomes and map the corresponding invoice resolution results in
SubscribeHtlcEvents.

This prevents HTLC event subscriptions from terminating with an unknown
failure-resolution error for these outcomes and gives subscribers stable,
specific failure details instead of UNKNOWN.

The original release-note entry is moved from the 0.21.0 notes to the active
0.20.5 notes, and the protobuf artifacts are regenerated with the current
20.x toolchain.

Verification

  • make rpc-check
  • go test ./lnrpc/...

@ziggie1984
ziggie1984 force-pushed the backport-10520-to-v0.20.x-branch branch from d2fc1b8 to e5046bd Compare September 23, 2026 11:59

@ziggie1984 ziggie1984 left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM needed for #11224

@ziggie1984
ziggie1984 merged commit ff5bbde into lightningnetwork:v0.20.x-branch Sep 23, 2026
31 of 35 checks passed
@github-actions github-actions Bot added the severity-high Requires knowledgeable engineer review label Sep 23, 2026
@github-actions

Copy link
Copy Markdown

🟠 PR Severity: HIGH

gh pr view | 5 files | 150 lines changed

🟠 High (4 files)
  • lnrpc/routerrpc/router.proto - RPC/API definition change (new field)
  • lnrpc/routerrpc/router.pb.go - auto-generated from the proto change above
  • lnrpc/routerrpc/router.swagger.json - auto-generated swagger spec from the proto change
  • lnrpc/routerrpc/subscribe_events.go - router RPC event subscription logic updated to use the new field
🟢 Low (1 file)
  • docs/release-notes/release-notes-0.20.5.md - release notes entry

Analysis

All substantive changes live under lnrpc/routerrpc/*, which falls under the HIGH severity tier (RPC/API definitions). The change adds a field to router.proto and threads it through the regenerated router.pb.go/router.swagger.json and subscribe_events.go. No CRITICAL packages are touched, and excluding the auto-generated router.pb.go, the PR is small (~4 substantive files, ~34 non-generated lines), so no severity bump applies.


To override, add a severity-override-{critical,high,medium,low} label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

severity-high Requires knowledgeable engineer review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants