invoices: bound rapid migration test workload

[ziggie1984]

Change

TestMigrateSingleInvoiceRapid performed Rapid's default 100 property checks,
but generated and migrated another 100 invoices inside every check for both
SQLite and Postgres. The resulting 20,000 migrations and delayed database
cleanup made the race build exceed the Postgres fixture's fixed ten-minute
lifetime.

• Run SQLite and Postgres as separate subtests so the Postgres fixture lifetime
  covers only Postgres checks.
• Close each database when its Rapid property check finishes instead of
  retaining every handle until the outer test exits.
• Migrate a bounded batch of ten randomized invoices per property check. This
  retains multiple migrations in one transaction and post-commit lookup
  coverage while replacing the accidental 100-by-100 multiplier with 1,000
  generated invoices per backend.

This addresses the repeated race-job timeout observed after the Go 1.27.1
toolchain update in #11200 without increasing the fixture timeout.

Verification

• Full Go 1.27.1 race run of TestMigrateSingleInvoiceRapid: pass in 142.330s.
• Fixed-seed 20-check comparison: 30.884s, down from 65.900s.
• make lint-native: 0 issues.

[github-actions]

🟢 PR Severity: LOW

override label | 1 files | 132 lines changed

🟢 Low (1 files)

• invoices/sql_migration_test.go - test-only file (*_test.go)

Analysis

A severity-override-low label is present on this PR, so automatic classification was skipped and the override was applied directly. For reference, the only file changed (invoices/sql_migration_test.go) is a test file, which would independently classify as LOW under the standard rules.

---

_{To override, add a severity-override-{critical,high,medium,low} label.}

[Lrifton92]

Reviewed at 381faa6.

The restructuring matches the description. Each backend runs as its own subtest, so the Postgres fixture only lives through the Postgres checks. Every Rapid check gets a fresh store, whose handle is closed in rt.Cleanup rather than kept until the outer test exits. The per-check batch goes from 100 invoices to 10, which removes the accidental 100×100 multiplier while still putting several migrations in one transaction.

Two changes are improvements beyond the timeout fix:

• The ExecTx closure now returns the MigrateSingleInvoice error instead of calling require.NoError inside it. FailNow from inside the transaction callback would bypass the executor's rollback and retry handling.
• The map becomes a slice, so the migration order within a check is deterministic, which helps when Rapid replays a failure.

What I ran on this head:

• TestMigrateSingleInvoiceRapid/SQLite passes: "[rapid] OK, passed 100 tests". The early db.Close() plus the helper's own cleanup close is exercised on this path without error, since sql.DB.Close is idempotent.
• The Postgres subtest needs Docker, which I don't have here, so that half is unverified locally.
• To check that 10 invoices per check still gives useful coverage, I added a break after the first InsertInvoiceHTLCCustomRecord in sql_migration.go, so only one custom record per HTLC is migrated. Rapid fails immediately ("failed after 0 tests") and shrinks to a minimal invoice. So a data-loss bug on a common shape is still caught at the new batch size. Rarer combinations get fewer draws than before (1,000 generated invoices per backend instead of 10,000), which is the stated trade-off.
• go vet ./invoices/ is clean and no added line exceeds 80 columns.

Minor, non-blocking: each check's Postgres CREATE DATABASE and each SQLite temp dir are still registered on the subtest's t (sqldb/postgres_fixture.go:158, sqldb/sqlite.go:236), so 100 of them accumulate until the subtest ends. The handles are closed early, which is what matters for the fixture, but the comment at lines 583-585 could say the databases themselves stay until the subtest ends.

LGTM.

[bhandras]

LGTM

[hieblmi]

LGTM

[saubyk]

Ack

[github-actions]

Successfully created backport PR for v0.20.x-branch:

• [v0.20.x-branch] Backport #11206: invoices: bound rapid migration test workload #11214

[github-actions]

Successfully created backport PR for v0.21.x-branch:

• [v0.21.x-branch] Backport #11206: invoices: bound rapid migration test workload #11215