docs(timezones): drop experimental gating from convert_timezone and embed timezone - #1241
Merged
Merged
Conversation
…mbed timezone Timezone support is on by default for every deployment, so neither the convert_timezone dimension override nor the embed timezone URL param needs enabling by support. Remove the Experimental badge and the contact-support wording, and describe the self-hosted opt-out instead.
Contributor
Documentation validation✅ All blocking checks passed. Component system0 finding(s) across the corpus. Findings on lines this pull request touched are annotated inline in Files changed. |
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates: https://linear.app/lightdash/issue/GLITCH-520
Relates: https://linear.app/lightdash/issue/GLITCH-340
Description
Timezone support is enabled by default on every deployment (lightdash/lightdash#26295), so the docs should stop saying these pieces need enabling by support:
semantic-layer/dimensions.mdx: theconvert_timezoneoverride loses its[Experimental]tag in the reference table and the Experimental badge callout. The callout now only notes that the override needs a project query timezone to have any effect.embed/iframe.mdx: the embedtimezoneparam no longer says to contact support. It is available to all organizations; the callout now explains that a self-hosted instance running withLIGHTDASH_ENABLE_TIMEZONE_SUPPORT=falseignores the param. The Beta badge stays since it describes API stability, not gating.The
LIGHTDASH_ENABLE_TIMEZONE_SUPPORTrow in the environment variable reference was already corrected in #1240.Validation:
git diff --checkpassed.