Update study PGN example. - #666
Open
ddobbelaere wants to merge 1 commit into
Open
Conversation
ddobbelaere
force-pushed
the
bugfix/update-study-pgn-example
branch
from
July 30, 2026 18:26
a77eb09 to
c96afe8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update example in
StudyPgnschema to the latest version, as quite a few things have changed to the tags.I noticed that the
StudyPgnschema is also used in some broadcast endpoints, unfortunately. This is large "overshadowed" in the interface by the fact that these endpoints also provide explicit examples, but this does not seem so clean to me. Maybe we should have a genericPgnschema of type string without an explicit example?This would also allow us to get rid of
StudyPgn(and use the new opaquePgnschema) by defining explicit examples in the examples folder for all use cases, similar to how we do it with the broadcasts. This has the advantage that we can differentiate the examples better (e.g. export all chapters is now just the single chapter). If this would have been the case already, I imagine this PR would not have existed, as @fitztrev would likely have updated it in a0f82d0.What do you think?