Planet survey / knowledge / star-map Address Library IDs and helpers#43
Open
pjmagee wants to merge 1 commit into
Open
Planet survey / knowledge / star-map Address Library IDs and helpers#43pjmagee wants to merge 1 commit into
pjmagee wants to merge 1 commit into
Conversation
pjmagee
changed the title
Contributor
|
Please keep code comments to a bare minimum (a lot of it is self explanatory or unecessary), and remove them all from the IDs header |
pjmagee
marked this pull request as draft
July 18, 2026 15:36
Author
|
Addressed — comments removed from the IDs header and trimmed elsewhere to bare minimum (offset/// members only where the tree already does). |
Address Library IDs and thin headers for BGSPlanet::Manager, BSGalaxy::PlayerKnowledge, ScannableComponent, MiscStatManager, and related survey/star-map paths (1.16.236–1.16.244). Based on Complete Planet Survey.
pjmagee
force-pushed
the
upstream-contributions
branch
from
July 18, 2026 15:39
6022d60 to
e1e83b3
Compare
Author
|
Also squashed commits, keeps it simpler |
pjmagee
marked this pull request as ready for review
July 19, 2026 15:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributions based on my Complete Planet Survey mod (Starfield 1.16.236–1.16.244).
Adds verified Address Library IDs and thin helpers for galaxy knowledge, survey notify/aggregator, star-map scan/panel paths, scannable, and misc-stat table layouts.