Repository navigation
feat!: separate role memberships from schema grants - #64
Merged
Merged
Conversation
createAdminGrants and createReaderGrants no longer take a list of logins or grant role membership. Schema grants require the schema owner, while memberships require ADMIN OPTION on the role, so no single non-superuser connection could run both. Use the new ServerClient.createMemberships on the CREATEROLE connection to grant memberships. The methods also no longer skip the schema grants when there are no logins. Fixes #63
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 701 708 +7
Branches 23 85 +62
=========================================
+ Hits 701 708 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createAdminGrantsandcreateReaderGrantsno longer take a list of logins or grant role membership. Schema grants require the schema owner, while memberships requireADMIN OPTIONon the role, so no single non-superuser connection could run both. Use the newServerClient.createMembershipson theCREATEROLEconnection to grant memberships.The methods also no longer skip the schema grants when there are no logins.
Fixes #63