Repository navigation
fix(video): regression introduced by #19938 in threaded cached-frame replay - #19949
Merged
Merged
Conversation
Populate widgets_visible on the video thread during cached-frame replay, which bypasses the normal worker loop. Keep UI composition and HDR decisions consistent with the widgets being drawn without advancing their animations again. Extend the replay tests to cover visible widgets and stale visibility after widgets are disabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a regression introduced by #19938 in threaded cached-frame replay.
Widget visibility is now cached in
video_frame_info_t, butvideo_thread_frame_replay()bypasses the worker loop that normallypopulates it. Screenshot readbacks and Windows resize/move redraws can
therefore reach the backend with
widgets_visible=falseeven whenwidgets are drawn, affecting UI composition and HDR brightness decisions.
Refresh widget visibility in the inline replay path, on the video thread,
without advancing widget animations again. Add regression coverage for
visible widgets and for clearing stale visibility when widgets are disabled.
Validation:
Reviewers
@LibretroAdmin