Repository navigation
feat(ps3): add native libretro RSX hardware rendering support - #19930
Closed
jhonathanc wants to merge 2 commits into
Closed
jhonathanc wants to merge 2 commits into
jhonathanc wants to merge 2 commits into
Conversation
Expose an experimental libretro RSX context and versioned rendering interface for PSL1GHT cores. Present core-owned RSX textures without CPU uploads, share the command FIFO and unused host mapping, and defer allocation retirement until queued GPU work completes. Integrate context negotiation and enforce main-thread rendering. Restore frontend GPU state before compositing and use fenced per-font vertex pages to prevent oversized Ozone batches from corrupting queued text. Invalidate the vertex cache before menu and font draws. Make the RSX host allocation configurable at build time. Extend regression coverage for hardware image validation, deferred resource retirement, oversized font batches and allocation failures.
Give the RSX context and render interface proper IDs in libretro.h (RETRO_HW_CONTEXT_RSX = 11, RETRO_HW_RENDER_INTERFACE_RSX = 6) and ship one interface, version 1, with retire_memory in it, instead of two versions picked through the context's version_major. Retired memory goes on a ring and is covered by one label write per frame, with no wait-for-idle and no flush per call. Font vertex pages are all allocated with the font, and batches bigger than a page are drawn in page-sized pieces, so nothing is allocated while drawing. When the menu shows over a duped frame from a hardware core, the core's image is drawn behind it rather than the software texture. The frontend state reset runs only on frames the core rendered. The host mapping default stays 32 MB; RSX_HOST_SIZE still overrides it. The PSL1GHT guards around the new code are dropped: the driver only builds with HAVE_GCM, which only Makefile.psl1ght sets.
Contributor
|
Check if everything still works with my rebased patch |
Contributor
|
This has been pushed to master already. Superseded. Let me know if theres anything wrong with the implementation and if so, send a followup PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Expose an experimental libretro RSX context and versioned rendering interface for PSL1GHT cores. Present core-owned RSX textures without CPU uploads, share the command FIFO and unused host mapping, and defer allocation retirement until queued GPU work completes.
Integrate context negotiation and enforce main-thread rendering. Restore frontend GPU state before compositing and use fenced per-font vertex pages to prevent oversized Ozone batches from corrupting queued text. Invalidate the vertex cache before menu and font draws.
Make the RSX host allocation configurable at build time. Extend regression coverage for hardware image validation, deferred resource retirement, oversized font batches and allocation failures.
Reviewers
@LibretroAdmin