Repository navigation
fix(ci): embed the Studio chart before the release job's tests - #44
Merged
Merged
Conversation
The chart tests that coverage:check runs need the Studio chart that bun run embed downloads; installer-release.yml embedded it only inside bun run build, after the tests, so the tests fell back to helm dependency build without a Studio repository and failed the build job of installer-v1.1.0 (run 40053893784) before anything was published. The build job now embeds after the Studio checkout and before the tests, and the workflow test requires that order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tag
installer-v1.1.0failed in its build job (run 40053893784), and nothing was published: the chart tests incoverage:checkneed the Studio chart thatbun run embeddownloads, but the release job embedded it only insidebun run build, after the tests, so they fell back tohelm dependency buildwithout a Studio repository. #39 added Helm to that job but not this order.The build job now runs
bun run embedafter the Studio checkout and beforecoverage:check, andscripts/ci/workflows.test.tsrequires that order.Verified: in a clean worktree with an empty Helm repository config, the chart test fails without
embedandcoverage:checkpasses with it (966 tests, 100% lines);actionlint, root lint, typecheck andnpm testpass. After the merge,installer-v1.1.0is moved to the new merge commit, since it has no release.