Add operator to fetch cookies by their key - #1312
Merged
Merged
Conversation
COM8
requested changes
Jul 19, 2026
Comment on lines
+78
to
+82
| for (size_t i = 0; i < cookies_.size(); i++) { // NOLINT(*-loop-convert) | ||
| if (cookies_[i].GetName() == key) { | ||
| return cookies_[i]; | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Please use std::find_if. It should be available in C++17 (https://en.cppreference.com/cpp/algorithm/find).
Contributor
Author
There was a problem hiding this comment.
Are my changes satisfactory?
COM8
approved these changes
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main idea of this PR is to add the ability to fetch cookies by their individual key from a cpr::Cookies object. calling the
[]operator on a string storing the cookie name would return the actual cookie with that name, if not, it throwsstd::out_of_range. Looping through the list of cookies produces annoying boilerplate code, and this would fix that. I'm a new C++ programmer; worse yet, my introduction to C++ was with version 98, so I won't be offended by quite possibly a lot of feedback.I already have these concerns with my own PR, however.
std::out_of_rangeis the right way to handle that.