Skip to content

Fix test and namespace conflict. #991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evoskuil merged 2 commits into from
Oct 5, 2026
Merged

Fix test and namespace conflict. #991

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6fadf3
Qualify system symbols in the witness commitment tests.
evoskuil Oct 5, 2026
c6c9589
Associate the archived header in the candidate extension test.
evoskuil Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/query/confirmed.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ BOOST_AUTO_TEST_CASE(query_confirmed__is_candidate_extension__candidates__expect
BOOST_REQUIRE(query.is_candidate_extension(1));
BOOST_REQUIRE(!query.is_candidate_extension(2));

BOOST_REQUIRE(query.set(test::block1, context{ 0, 1, 0 }, {}, false, false));
BOOST_REQUIRE(query.set(test::block1, false, false));
BOOST_REQUIRE(!query.is_candidate_extension(1));
}

Expand Down
18 changes: 9 additions & 9 deletions test/query/properties_block.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ BOOST_AUTO_TEST_CASE(query_properties_block__is_witness_committed__genesis__head
BOOST_REQUIRE(query.initialize(test::genesis));

BOOST_REQUIRE(query.is_witness_committed(test::genesis.header().merkle_root(), 0));
BOOST_REQUIRE(!query.is_witness_committed(one_hash, 0));
BOOST_REQUIRE(!query.is_witness_committed(system::one_hash, 0));
}

BOOST_AUTO_TEST_CASE(query_properties_block__is_witness_committed__committed__expected)
Expand All @@ -278,17 +278,17 @@ BOOST_AUTO_TEST_CASE(query_properties_block__is_witness_committed__committed__ex
BOOST_REQUIRE(!store.create(test::events_handler));
BOOST_REQUIRE(query.initialize(test::genesis));

const hash_digest reserved_hash{ 0x02 };
const auto commitment = bitcoin_hash(one_hash, reserved_hash);
const script commitment_script(splice(base16_chunk("6a24aa21a9ed"), commitment), false);
const witness reserved{ chunk_cptrs{ to_shared(to_chunk(reserved_hash)) } };
const inputs ins{ input{ point{}, script{ operations{ operation{ data_chunk{ 0x01, 0x02 }, false } } }, reserved, 0xffffffff } };
const system::hash_digest reserved_hash{ 0x02 };
const auto commitment = system::bitcoin_hash(system::one_hash, reserved_hash);
const script commitment_script(system::splice(system::base16_chunk("6a24aa21a9ed"), commitment), false);
const witness reserved{ system::chunk_cptrs{ system::to_shared(system::to_chunk(reserved_hash)) } };
const inputs ins{ input{ point{}, script{ operations{ operation{ system::data_chunk{ 0x01, 0x02 }, false } } }, reserved, 0xffffffff } };
const transaction coinbase{ 1, ins, outputs{ output{ 0, commitment_script } }, 0 };
const block block1{ header{ 1, test::genesis.hash(), null_hash, 0, 0, 0 }, transactions{ coinbase } };
BOOST_REQUIRE(query.set(block1, context{}, {}, false, false));
const block block1{ header{ 1, test::genesis.hash(), system::null_hash, 0, 0, 0 }, transactions{ coinbase } };
BOOST_REQUIRE(query.set(block1, database::context{}, {}, false, false));

const auto link = query.to_header(block1.hash());
BOOST_REQUIRE(query.is_witness_committed(one_hash, link));
BOOST_REQUIRE(query.is_witness_committed(system::one_hash, link));
BOOST_REQUIRE(!query.is_witness_committed(reserved_hash, link));
}

Expand Down
Loading