Add a side hierarchic nodal soln implementation#4494
Open
lindsayad wants to merge 1 commit into
Open
Conversation
Co-authored-by: Codex <codex@openai.com>
Member
Author
|
If we agree on this implementation, I'd probably go and temporarily skip the affected MOOSE tests |
Member
Author
|
This is how
With this PR: CONSTANT SIDE_HIERARCHIC side_var
With this PR: FIRST SIDE_HIERARCHIC aux_side_var
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Given the previous comment here (which I've temporarily kept), I anticipate some debate on this, although I think the implementation is defensible given what we already do for projecting discontinuous solutions onto nodes for other output cases