fix: use environment HTTP proxies for CDP connections - #30
Open
TristanIsK wants to merge 4 commits into
Open
TristanIsK wants to merge 4 commits into
TristanIsK wants to merge 4 commits into
Conversation
TristanIsK
marked this pull request as ready for review
September 18, 2026 10:55
TristanIsK
commented
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cloud agents with mandatory HTTP proxies can create browser sessions through reqwest, but CDP WebSocket actions fail with DNS errors because tungstenite connects directly. This change makes the shared CDP connection honor HTTP_PROXY, HTTPS_PROXY, ALL_PROXY and NO_PROXY using the existing hyper-util matcher, establishing HTTP CONNECT before the normal WebSocket/TLS handshake.
Proxy credentials are limited to CONNECT. TLS and hostname verification remain enabled; rejected proxies do not fall back to direct access. WebSocket redirects retain the original three-hop limit and rematch the environment proxy/NO_PROXY for every destination, including direct-to-proxy transitions. CONNECT headers and connection/handshake waits are bounded. This supports HTTP CONNECT proxies; HTTPS-to-proxy and SOCKS proxy schemes return explicit errors. CLI and both bootstrap scripts are prepared for version 1.2.1.
Validation on review-fix head 92e7c4b:
Earlier cloud/source validation on af092b0:
Release dependency: this is a source candidate, not a published CLI artifact. The plugin 1.1.19 draft pins CLI 1.2.1 and must be submitted only after the official CLI 1.2.1 release assets are available. No PR merge or release was performed.