feat(review)!: clipboard yank and focus-maximize replacing zoom - #89
Draft
lettertwo wants to merge 22 commits into
Draft
feat(review)!: clipboard yank and focus-maximize replacing zoom#89lettertwo wants to merge 22 commits into
lettertwo wants to merge 22 commits into
Conversation
lettertwo
changed the title
lettertwo
force-pushed
the
review/12-clipboard-focus-sweep
branch
from
September 4, 2026 18:14
5f12598 to
15bf839
Compare
lettertwo
force-pushed
the
review/12-clipboard-focus-sweep
branch
from
September 4, 2026 21:13
15bf839 to
c55f09b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the four-state zoom enum with focus plus maximize, per ADR-038 (focus-maximize replaces zoom). The
Zcycle and theworkon.review.diff.zoomsetting go away, which is the breaking change in the title.Role::Combinedis renamedRole::Whole, a single staged or unstaged pane names its role, and staging hints hide where staging can only refuse.Clipboard:
ysplits into range-aware copy-lines and copy-location (path:line) over OSC 52; a failed clipboard write keeps the selection. A stale-diff align race is tolerated and self-healed, and the index is reloaded before reading a staged blob.The rest is a mechanical sweep: milestone, trap, and changeset labels in comments, docs, and test names across the review crate,
git-workon-lib, andgit-workonare replaced by descriptive names, and swept comments are rewrapped to 100 columns.