feat(review): source changesets from the stack with an outline pane - #81
Draft
lettertwo wants to merge 10 commits into
Draft
feat(review): source changesets from the stack with an outline pane#81lettertwo wants to merge 10 commits into
lettertwo wants to merge 10 commits into
Conversation
lettertwo
force-pushed
the
review/04-stack-outline
branch
from
September 4, 2026 18:14
e4b04e4 to
babf01c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sources the review from the changeset stack instead of only the uncommitted worktree. Committed changesets render read-only, the uncommitted layer becomes one changeset inside the stack, and
]c/[cnavigate between them. An outline pane lists files in flat, tree, stack, and stack-tree modes.It also makes the binary a
COMPLETE=responder for dynamic completion and renders to/dev/ttyso capturing stdout no longer hangs.Two fixes surfaced during this work and are pinned by tests: a committed changeset's old side reads its base commit's tree rather than live
HEAD, and attribution is skipped for committed changesets since empty membership sets miscolored every added cell as already staged.