feat(review): add the review crate diff engine and patch synthesis - #78
Draft
lettertwo wants to merge 18 commits into
Draft
feat(review): add the review crate diff engine and patch synthesis#78lettertwo wants to merge 18 commits into
lettertwo wants to merge 18 commits into
Conversation
lettertwo
changed the title
lettertwo
force-pushed
the
review/01-engine
branch
from
September 4, 2026 18:14
43c4186 to
7a4b10a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
git-workon-reviewcrate as a library plus an empty binary, holding the engine the TUI is built on: a diff model built fromgit2diffs, line-precise patch synthesis with direction rules, patch appliers over bothgit2and the git CLI, a FIFO staging queue, and a refresh coordinator with generation supersede.The crate is
publish = falseanddist = false, so landing it changes nothing about releases. Placement is recorded in ADR-033 (review crate workspace placement); the git2-vs-CLI verdict and the exec-bit and EOFNL divergences it turned up are in the RFC.Outside the crate:
git-workon-fixturegains ahas_index_modepredicate and index-state builders, which the round-trip corpus tests use to pin file-mode behavior.