fix(api): preserve cancellation ABI and expose inbound route domains - #57
Merged
Merged
Conversation
Bjornftw
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Use a covariant return bridge to restore the original PR #53 JVM cancellation descriptor while retaining CancelScheduledMessageResponse for current callers. Expose optional nullable inboundRouteDomain.
Source contract
The combined specification was exported from revision cc20d3a24c8e1fdfc18dc3ced7a49071505dfba4, then split in a temporary workspace with the current docs script. Both outputs match the stored docs bytes. No source specification was changed or copied into this repository.
Team SHA-256: d29092db4b56011987088aadd8b71d2e3fe8a242441b206bfa6cf49d7409c31e.
Local validation
48 JUnit tests; Gradle build; an old compiled caller runs against the new SDK and a mock HTTP server. javap confirms both cancellation return descriptors.
Compatibility
This change adds a field or corrects contract checks. It does not remove a public method or type.
This PR does not merge or release the SDK.