[18.0][FIX] sentry_client: review rework preview (config fallback + systray) - #16
Closed
dnplkndll wants to merge 2 commits into
Closed
[18.0][FIX] sentry_client: review rework preview (config fallback + systray)#16dnplkndll wants to merge 2 commits into
dnplkndll wants to merge 2 commits into
Conversation
…nfig Backport of the 19.0 module (OCA#3622) to 18.0. Identical feature set; only the API surfaces that changed between series are adapted: - `user.all_group_ids` (19.0) → `user.groups_id` (18.0). 19.0 split the groups field into a stored direct collection plus a computed transitive closure; on 18.0 `groups_id` already returns the full set. - `group.privilege_id.category_id` (19.0) → `group.category_id` (18.0). 19.0 introduced the privilege layer between groups and categories; on 18.0 groups carry the category directly. - Manifest version `18.0.1.0.0`. Everything else — Connection UI block (Browser DSN / Environment / Release) with `odoo.conf [sentry]` fallback, four tier toggles with sample-rate knobs, vendored Sentry SDK under `static/lib`, OWL ErrorBoundary capturing the wrapping error and dedup-marking it, per-tab UUID + `workflow_id` + `surface` tags, per-user replay opt-out, and the public `/sentry_client/config.json` endpoint — ports verbatim. The OWL `error_handlers` registry, settings `<block>`/`<setting>` pattern, and asset bundle keys are identical between 18.0 and 19.0.
Review rework for ChristophAbenthungCibex: - Config fallback now reads the top-level sentry_* options from odoo.conf's [options] section — the layout the server-side sentry module actually uses on 18.0 (the dedicated [sentry] section only exists from 19.0), so the documented shared-DSN setup works. - Systray launcher restyled as o_nav_entry (the core idiom for a plain navbar launcher, e.g. the burger menu) instead of btn btn-link, which skipped the navbar entry height/padding and rendered misaligned. - Icon fa-bug -> fa-bullhorn: fa-bug is the debug-mode systray icon sitting right next to it; fa-bullhorn matches Sentry's own feedback iconography. Assisted-by: Claude Opus 5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork-only runboat preview of the rework for ChristophAbenthungCibex's review on OCA#3627. Not for merge — will be folded into the [ADD] commit on the real PR branch after UI verification.
sentry_*keys (18.0 layout) instead of the 19.0-only[sentry]section — proven live against stock odoo:18.0.o_nav_entry+fa-bullhornreplacing the misalignedbtn btn-link+ duplicatefa-bug.AI-assisted (Claude Code); every change reviewed, tested, and owned by the author.