[REVIEW] dms_preview_pane: preview-load race + translatable Details labels - #33
Open
dnplkndll wants to merge 2 commits into
Open
[REVIEW] dms_preview_pane: preview-load race + translatable Details labels#33dnplkndll wants to merge 2 commits into
dnplkndll wants to merge 2 commits into
Conversation
Selecting rows faster than the ORM answers left two reads in flight with no ordering guard: the earlier one could resolve last and paint its file over the row the user actually had selected. Routes both reads of a load through one KeepLast so a superseded load never settles. Assisted-by: Claude Opus 5
The six definition-list labels were JS string literals, which the translation export does not pick up (template text is extracted, JS literals are not), leaving the Details tab English in every language. Assisted-by: Claude Opus 5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrections found reviewing OCA/dms#483. Base is that PR's head, so this diff is only the fixes; they fold into the
[ADD]before the upstream force-push.KeepLastaround both reads. Mutation-checked — without the guard the new test failsExpected: 2, Received: 1.Hoot 20/20 (was 19); pre-commit green.
AI-assisted (Claude Code); every change reviewed, tested, and owned by the author.