Repository navigation
Fix list[Literal] fields rejecting valid values - #380
Open
anishpentyala wants to merge 2 commits into
Open
anishpentyala wants to merge 2 commits into
anishpentyala wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #374.
get_argparse_type_for_container()currently returns the rawLiteral[...]annotation as the argparse item converter.Literalis not callable, so list fields reject valid input such as--colors red green.Use the existing
parse_literal()converter for Literal item types, just as this function already delegates Enum items toparse_enum(). This keeps validation and the actual literal value types, including integer literals. No new parser or dependency is added.Add regressions for string literals, integer literals, and optional list containers. They cover defaults, valid multiple values, and rejection of values outside the Literal choices. The scope is list containers with Literal items; this does not add support for nested Optional item types or sets.
Validation
Python 3.12.15, pytest 9.2.0, same local environment:
The shared failure is
test_bool_args_in_help, the pre-existing master help-text mismatch addressed separately by #379. Full-suite commands use-o addopts=''; these are not claims about the complete hosted matrix or doctest coverage.The changed files pass Ruff 0.1.14 lint/format checks and the project's pinned docformatter revision. Hosted CI is pending.