Repository navigation
fix: Serialization of Union[float, bool] fields - #373
Open
Rainyyyyyyy111 wants to merge 1 commit into
Open
Rainyyyyyyy111 wants to merge 1 commit into
Rainyyyyyyy111 wants to merge 1 commit into
Conversation
OSS-Contributor-Artifact: 357a3deeea40cb0196c2507048e184436af7cccea7b9fb0b5579e6ce3653d30f
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #264
Union decoding accepted the first successful conversion in annotation order, allowing booleans and floats to be coerced into another numeric member before their own decoder was tried.
Prefer the matching bool, int, or float decoder for numeric union values, retaining annotation-order fallback and enum/string decoding behavior. Add JSON round-trip coverage for float/bool unions in both orders, including optional unions.
Validation: the regression fails on the original code and passes with the fix; the configured test suite and checks pass.
AI-assisted with Codex; independently tested by OSS Contributor.