Repository navigation
Add drone renders to docs - #126
Merged
Merged
Conversation
ratheron
force-pushed
the
feature.drone_renders
branch
from
October 9, 2026 10:03
198aabf to
7175994
Compare
ratheron
marked this pull request as ready for review
October 9, 2026 10:04
amacati
requested changes
Oct 9, 2026
amacati
left a comment
amacati
left a comment
Collaborator
There was a problem hiding this comment.
Looks mostly good to go, just a question around the except blocks.
Comment on lines
+26
to
+29
| try: | ||
| import mkdocs_gen_files | ||
| except ImportError: | ||
| pass # not running in a docs environment — nothing to generate |
Collaborator
There was a problem hiding this comment.
Do we really want to use try-except here? When would this script ever run outside a docs env? I think this should just throw
Comment on lines
+92
to
+99
| def gl_available() -> bool: | ||
| """Check for a usable OpenGL context, so an unusable one is reported only once.""" | ||
| try: | ||
| mujoco.Renderer(mujoco.MjModel.from_xml_string("<mujoco/>"), 4, 4).close() | ||
| except Exception as e: | ||
| log.warning(f"Could not create an OpenGL context, skipping the drone renders: {e!r}") | ||
| return False | ||
| return True |
Collaborator
There was a problem hiding this comment.
Same here. We should not hide errors, not even in the docs. The script is only expected to run when this is available, right?
Comment on lines
+103
to
+107
| try: | ||
| image = render(drone) | ||
| except Exception as e: | ||
| log.warning(f"Could not render drone '{drone}': {e!r}") | ||
| continue |
Collaborator
There was a problem hiding this comment.
Same here. Why bare excepts?
Collaborator
Author
|
Added conftest to catch new errors (instead of adding a new flag to the pixi task) |
amacati
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs have a section for drone renders which was previously commented out. Added automatic render generation. Had to add dependencies to the docs env for headless rendering without a GPU driver.