feat: add monad-polymorphic sorts - #861
Open
eric-wieser wants to merge 4 commits into
Open
Conversation
These can be used to: * replace the specialized timeM version * implement sorts that log as they sort * specialize to FreeM or PFunctor.FreeM
eric-wieser
requested review from
chenson2018,
fmontesi and
sorrachai
as code owners
September 3, 2026 23:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These can be used to:
The old copyright dates on these files are because they were written by directly copying the corresponding non-monadic code from mathlib / lean core.
As a general pattern, writing code monad generically, then specializing it, allows Lean's compiler to compile it efficiently in
Id, but also allows it to be reasoned about for richer monadsm. The alternative of starting with a rich monad likeFreeMand transporting back toIdhas two downsides:FreeM.FreeM.liftM/TimeM.retto match performance characteristics.If you have no intent of ever executing the code then these concerns don't matter all that much. For now, the main benefit to CSLib is that we can write the algorithms just once while exploring a zoo of computation models to evaluate them in.