Improve how references are used throughout Physlib - #1613
Conversation
|
Thank you for this pull-request (PR). If this is your first PR, welcome to the community! Below is what will happen next. Please read carefully if you are not familiar with the process. You may open other PRs while this one is being reviewed, and can stack PRs on top of each other, so don't let these steps slow you down.
Tip: The easiest way to get have a fast review is to submit a PR that is small and self-contained, and has clear documentation explaining why things are the way they are in your chages. If you have any problems or questions, please reach out to the community on the Zulip. |
|
Very big PR - important files are references.bib and check_references.py |
|
Could you make a comment on the relevant Zulip channel about this? |
ae204b4 to
7b696c0
Compare
There was a problem hiding this comment.
Delete this file and all .axiomatic
| note = {title not stated in the citing module(s)} | ||
| } | ||
|
|
||
| @misc{arxiv_1401_5084, |
There was a problem hiding this comment.
These should be filled out correctly.
morrison-daniel
left a comment
There was a problem hiding this comment.
Can't attest to the linter files but I checked the references and they look good, with a few suggestions.
|
The style is much more uniform but we should probably discuss what should/shouldn't be in the reference section of the module. As it is now, the style guide is:
The variations on point 3 are
I could go either way on author inclusion, it would probably nice to include them but they are in the full bib file so I think we could remove them and rely on the link to the full reference. Removing would help keep it shorter and I think the doc-strings are already too long. Again, italics is probably more correct but this isn't an actual citation. No italics is much more common, but we just need to pick one. I would say no formatting just to keep it simple. Link is another one I'm not sure about since they're very convenient but take up space. Many are arXiv links, but many arXiv refs just use the I think what we have here is already an improvement and I don't want to hold this up with more discussion so I'd be happy to merge this and make edits when we hash out some details. |
Co-authored-by: Daniel Morrison <39346894+morrison-daniel@users.noreply.github.com>
Co-authored-by: Daniel Morrison <39346894+morrison-daniel@users.noreply.github.com>
Co-authored-by: Daniel Morrison <39346894+morrison-daniel@users.noreply.github.com>
Co-authored-by: Daniel Morrison <39346894+morrison-daniel@users.noreply.github.com>
Co-authored-by: Daniel Morrison <39346894+morrison-daniel@users.noreply.github.com>
Co-authored-by: Daniel Morrison <39346894+morrison-daniel@users.noreply.github.com>
Co-authored-by: Daniel Morrison <39346894+morrison-daniel@users.noreply.github.com>
Co-authored-by: Daniel Morrison <39346894+morrison-daniel@users.noreply.github.com>
Co-authored-by: Daniel Morrison <39346894+morrison-daniel@users.noreply.github.com>
morrison-daniel
left a comment
There was a problem hiding this comment.
I'm happy at this point so I'll leave the approval and mark this as ready-to-merge. @jstoobysmith if you're happy go ahead and merge.
check_references.pywhich uses regex to check these rules are followed (Similar tolint_bib.shin mathlib)