Skip to content

chore: deprecate sub_lt_zero - #43982

Open
Parcly-Taxel wants to merge 1 commit into
leanprover-community:masterfrom
Parcly-Taxel:subltzero
Open

Parcly-Taxel wants to merge 1 commit into
leanprover-community:masterfrom
Parcly-Taxel:subltzero

Conversation

@Parcly-Taxel

Copy link
Copy Markdown
Collaborator

It is a strictly longer alias of sub_neg and therefore wholly redundant.

It is a strictly longer alias of `sub_neg` and therefore wholly redundant.
@Parcly-Taxel Parcly-Taxel added the easy < 20s of review time. See the lifecycle page for guidelines. label Sep 20, 2026
@github-actions

github-actions Bot commented Sep 20, 2026

Copy link
Copy Markdown

PR summary 3212c3f00c

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 3212c3f).

  • +0 new declarations
  • −0 removed declarations

No declaration differences.


No changes to strong technical debt.
No changes to weak technical debt.

Current commit 3212c3f00c
Reference commit b1007d8abf

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.py pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@themathqueen

Copy link
Copy Markdown
Member

I don't think we should deprecate this alias. I don't think it being a longer name means we should deprecate it. sub_neg can sound like a - -b, so having a more descriptive alias is helpful.

@themathqueen themathqueen added awaiting-author Reply -awaiting-author to remove the label on your PR once you have addressed all comments. and removed easy < 20s of review time. See the lifecycle page for guidelines. labels Sep 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-author Reply -awaiting-author to remove the label on your PR once you have addressed all comments.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants