Conversation
PR summary b1095e016dImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
Contributor
|
You can also use |
Contributor
Author
|
I just copied what was done in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where turning on
pp.mdatacauses constants tagged with@[pp_with_univ]to print asWhen
pp.mdatais set to true, expressions with mdata are printed by first printing the mdata and the printing the bare expression underneath. This breaks@[pp_with_univ]which works by applying mdata settingpp.universesto true onto the constant name, and then redelaborating the new expression containing mdata. This causes an infinite loop the the delaborator since@[pp_with_univ]applies the mdata, and then sincepp.mdatais true the mdata is removed before delaborating the constant, which then has mdata applied again, and so on. We fix the issue by instead having the implementation of@[pp_with_univ]directly set thepp.universesoption, instead of delegating it todelabMDatawith a metadata.