Skip to content

[Merged by Bors] - feat(Analysis/Normed): norm and {List, Multiset}.prod commute - #43979

Closed
wwylele wants to merge 3 commits into
leanprover-community:masterfrom
wwylele:multiset-prod-norm
Closed

wwylele wants to merge 3 commits into
leanprover-community:masterfrom
wwylele:multiset-prod-norm

Conversation

@wwylele

@wwylele wwylele commented Sep 19, 2026

Copy link
Copy Markdown
Collaborator

Similar to Finset.prod lemmas above, provides convenient rewriting lemma.


Open in Gitpod

@wwylele

wwylele commented Sep 19, 2026

Copy link
Copy Markdown
Collaborator Author

easy

@github-actions github-actions Bot added the easy < 20s of review time. See the lifecycle page for guidelines. label Sep 19, 2026
@github-actions

github-actions Bot commented Sep 19, 2026 •

Copy link
Copy Markdown

PR summary 1f68b87363

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ List.nnnorm_prod_map
+ List.norm_prod_map
+ Multiset.nnnorm_prod
+ Multiset.nnnorm_prod_map
+ Multiset.norm_prod
+ Multiset.norm_prod_map

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

✅ Lean-aware diff — post-build, computed from the Lean environment (commit 1f68b87).

  • +6 new declarations
  • −0 removed declarations
+List.nnnorm_prod_map
+List.norm_prod_map
+Multiset.nnnorm_prod
+Multiset.nnnorm_prod_map
+Multiset.norm_prod
+Multiset.norm_prod_map

No changes to strong technical debt.
No changes to weak technical debt.

Current commit 1f68b87363
Reference commit fd634dd297

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.py pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-analysis Analysis (normed *, calculus) label Sep 19, 2026
Comment thread Mathlib/Analysis/Normed/Ring/Basic.lean
Comment thread Mathlib/Analysis/Normed/Ring/Basic.lean
Comment thread Mathlib/Analysis/Normed/Ring/Basic.lean Outdated
@themathqueen themathqueen added the awaiting-author Reply -awaiting-author to remove the label on your PR once you have addressed all comments. label Sep 21, 2026
@wwylele

wwylele commented Sep 21, 2026

Copy link
Copy Markdown
Collaborator Author

Thanks for the suggestion!
-awaiting-author

@github-actions github-actions Bot removed the awaiting-author Reply -awaiting-author to remove the label on your PR once you have addressed all comments. label Sep 21, 2026
@themathqueen themathqueen changed the title feat(Analysis/Normed): norm and Multiset.prod commute feat(Analysis/Normed): norm and {Multiset, List}.prod commute Sep 21, 2026
@themathqueen themathqueen changed the title feat(Analysis/Normed): norm and {Multiset, List}.prod commute feat(Analysis/Normed): norm and {List, Multiset}.prod commute Sep 21, 2026

@themathqueen themathqueen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer merge

@github-actions

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by themathqueen.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Sep 21, 2026

@jcommelin jcommelin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@mathlib-bors mathlib-bors Bot added the ready-to-merge This PR has been sent to bors. label Sep 22, 2026
@mathlib-triage mathlib-triage Bot removed the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Sep 22, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Sep 22, 2026
Similar to Finset.prod lemmas above, provides convenient rewriting lemma.
@mathlib-bors mathlib-bors Bot added the bors-staging This PR is currently being built by bors on the staging branch. label Sep 22, 2026
@mathlib-bors

mathlib-bors Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

@mathlib-bors mathlib-bors Bot changed the title feat(Analysis/Normed): norm and {List, Multiset}.prod commute [Merged by Bors] - feat(Analysis/Normed): norm and {List, Multiset}.prod commute Sep 22, 2026
@mathlib-bors mathlib-bors Bot closed this Sep 22, 2026
grunweg pushed a commit to grunweg/mathlib4 that referenced this pull request Sep 22, 2026
…over-community#43979)

Similar to Finset.prod lemmas above, provides convenient rewriting lemma.
@wwylele
wwylele deleted the multiset-prod-norm branch September 22, 2026 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bors-staging This PR is currently being built by bors on the staging branch. easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants