Skip to content

Tfae block tactic - #43967

Draft
joneugster wants to merge 36 commits into
leanprover-community:masterfrom
joneugster:tfae-block-tactic
Draft

joneugster wants to merge 36 commits into
leanprover-community:masterfrom
joneugster:tfae-block-tactic

Conversation

@joneugster

@joneugster joneugster commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

Migration from #10991 since I would like to adopt this at some point.

Note to myself: #11003 once did some migration using the new syntax. However, I expect it will be easier to recreate this.

Open in Gitpod

thorimur and others added 30 commits February 17, 2024 03:34
@joneugster joneugster added the WIP Work in progress label Sep 19, 2026
@github-actions

github-actions Bot commented Sep 19, 2026 •

Copy link
Copy Markdown

PR summary 0178def2fe

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Tactic.TFAE 167 169 +2 (+1.20%)
Import changes for all files
Files Import difference
../mathlib-ci/scripts/pr_summary/import_trans_difference.sh all
There are 5963 files with changed transitive imports taking up over 270025 characters: this is too many to display!
You can run this locally from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci


Declarations diff (regex)

+ tfaeFields
- binder

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean -- pending)

Computed after the build finishes.


No changes to strong technical debt.
No changes to weak technical debt.

Current commit 0178def2fe
Reference commit c58b47adb3

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.py pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-meta Tactics, attributes or user commands label Sep 19, 2026
@joneugster
joneugster marked this pull request as ready for review September 20, 2026 13:08
@joneugster
joneugster marked this pull request as draft September 20, 2026 13:13
@mathlib-bors

mathlib-bors Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

This pull request is now in draft mode. No active bors state needed cleanup.

While this PR remains draft, bors will ignore commands on this PR. Mark it ready for review before using commands like bors r+ or bors try.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-meta Tactics, attributes or user commands WIP Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants