Skip to content

feat(Geometry/Euclidean): theorems to prove line parallel from relation between oangles - #43964

Open
benpigchu wants to merge 1 commit into
leanprover-community:masterfrom
benpigchu:transversal-on-parallel-lines
Open

benpigchu wants to merge 1 commit into
leanprover-community:masterfrom
benpigchu:transversal-on-parallel-lines

Conversation

@benpigchu

@benpigchu benpigchu commented Sep 19, 2026

Copy link
Copy Markdown

We have EuclideanGeometry.two_zsmul_oangle_of_parallel to derive relationship of oangles from parallel lines, but we do not have theorems to prove parallel of lines from relationship of oangles. This PR add theorems for that, and their iff version.


Open in Gitpod

@github-actions github-actions Bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Sep 19, 2026
@github-actions

Copy link
Copy Markdown

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR. The review dashboard has a dedicated webpage which shows whether your PR is on the review queue, and (if not), why.

If you haven't already done so, please come to Zulip and join the Lean community.
Thank you again for joining our community.

@github-actions

github-actions Bot commented Sep 19, 2026

Copy link
Copy Markdown

PR summary e676b4c63b

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ parallel_of_two_zsmul_oangle
+ span_eq_of_two_zsmul_oangle_eq_zero
+ span_eq_of_two_zsmul_oangle_left
+ span_eq_of_two_zsmul_oangle_right
+ two_zsmul_oangle_eq_zero_iff_span_eq
+ two_zsmul_oangle_iff_parallel
+ two_zsmul_oangle_iff_vectorSpan_eq
+ two_zsmul_oangle_left_iff_span_eq
+ two_zsmul_oangle_of_span_eq
+ two_zsmul_oangle_right_iff_span_eq
+ vectorSpan_eq_of_two_zsmul_oangle

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit e676b4c).

  • +11 new declarations
  • −0 removed declarations
+EuclideanGeometry.parallel_of_two_zsmul_oangle
+EuclideanGeometry.two_zsmul_oangle_iff_parallel
+EuclideanGeometry.two_zsmul_oangle_iff_vectorSpan_eq
+EuclideanGeometry.vectorSpan_eq_of_two_zsmul_oangle
+Orientation.span_eq_of_two_zsmul_oangle_eq_zero
+Orientation.span_eq_of_two_zsmul_oangle_left
+Orientation.span_eq_of_two_zsmul_oangle_right
+Orientation.two_zsmul_oangle_eq_zero_iff_span_eq
+Orientation.two_zsmul_oangle_left_iff_span_eq
+Orientation.two_zsmul_oangle_of_span_eq
+Orientation.two_zsmul_oangle_right_iff_span_eq

No changes to strong technical debt.
No changes to weak technical debt.

Current commit e676b4c63b
Reference commit dec5b2b780

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.py pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-euclidean-geometry Affine and axiomatic geometry label Sep 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-euclidean-geometry Affine and axiomatic geometry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants