Skip to content

feat(CategoryTheory): StructuredArrow.congr - #42645

Open
joelriou wants to merge 2 commits into
leanprover-community:masterfrom
joelriou:structured-arrow-congr
Open

joelriou wants to merge 2 commits into
leanprover-community:masterfrom
joelriou:structured-arrow-congr

Conversation

@joelriou

@joelriou joelriou commented Aug 11, 2026 •

Copy link
Copy Markdown
Contributor

The PR also removes a lot of set_option in the StructuredArrow files by making more definitions implicit_reducible.


This does not depend on #40940, but it would be easier to proceed with that to_dual PR first.
Because of #42816, it is now unclear whether I will need this.

Open in Gitpod

@joelriou joelriou added the t-category-theory Category theory label Aug 11, 2026
@github-actions github-actions Bot added the tech debt Fixes cross-cutting technical debt, see the "technical debt counters" stream on zulip label Aug 11, 2026
@github-actions

github-actions Bot commented Aug 11, 2026 •

Copy link
Copy Markdown

PR summary 6df16cbca1

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

++ congr
++ ι

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

✅ Lean-aware diff — post-build, computed from the Lean environment (commit 6df16cb).

  • +31 new declarations
  • −5 removed declarations
+CategoryTheory.Comma.costructuredArrowSndInclusion_obj
-CategoryTheory.Comma.costructuredArrowSndInclusion_obj_hom
-CategoryTheory.Comma.costructuredArrowSndInclusion_obj_left_hom
-CategoryTheory.Comma.costructuredArrowSndInclusion_obj_left_left
-CategoryTheory.Comma.costructuredArrowSndInclusion_obj_left_right
-CategoryTheory.Comma.costructuredArrowSndInclusion_obj_right_as
+CategoryTheory.CostructuredArrow.congr
+CategoryTheory.CostructuredArrow.congr_counitIso
+CategoryTheory.CostructuredArrow.congr_functor
+CategoryTheory.CostructuredArrow.congr_inverse
+CategoryTheory.CostructuredArrow.congr_unitIso
+CategoryTheory.CostructuredArrow.map₂Congr.congr_simp
+CategoryTheory.CostructuredArrow.map₂IsoPreEquivalenceInverseCompProj_hom_app_left
+CategoryTheory.CostructuredArrow.map₂IsoPreEquivalenceInverseCompProj_inv_app_left
+CategoryTheory.CostructuredArrow.ι
+CategoryTheory.CostructuredArrow.ι_app
+CategoryTheory.StructuredArrow.commaMapEquivalence_counitIso
+CategoryTheory.StructuredArrow.commaMapEquivalence_functor
+CategoryTheory.StructuredArrow.commaMapEquivalence_inverse
+CategoryTheory.StructuredArrow.commaMapEquivalence_unitIso
+CategoryTheory.StructuredArrow.congr
+CategoryTheory.StructuredArrow.congr_counitIso
+CategoryTheory.StructuredArrow.congr_functor
+CategoryTheory.StructuredArrow.congr_inverse
+CategoryTheory.StructuredArrow.congr_unitIso
+CategoryTheory.StructuredArrow.map₂Congr.congr_simp
+CategoryTheory.StructuredArrow.ι
+CategoryTheory.StructuredArrow.ι_app
+CategoryTheory.costructuredArrowOpEquivalence_counitIso
+CategoryTheory.costructuredArrowOpEquivalence_functor
+CategoryTheory.costructuredArrowOpEquivalence_inverse
+CategoryTheory.costructuredArrowOpEquivalence_unitIso
+CategoryTheory.structuredArrowOpEquivalence_counitIso
+CategoryTheory.structuredArrowOpEquivalence_functor
+CategoryTheory.structuredArrowOpEquivalence_inverse
+CategoryTheory.structuredArrowOpEquivalence_unitIso

Decrease in strong tech debt: (relative, absolute) = (10.17, 0.03)
Current number Change Type (strong)
385 -2 adaptation notes
4292 -61 backward.defeqAttrib.useBackward
3932 -47 backward.isDefEq.respectTransparency.types
No changes to weak technical debt.

Current commit 6df16cbca1
Reference commit e76467f1ca

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib-dependent-issues mathlib-dependent-issues Bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Aug 11, 2026
@mathlib-dependent-issues

Copy link
Copy Markdown

This PR/issue depends on:

@mathlib-merge-conflicts

Copy link
Copy Markdown

This pull request has conflicts, please merge master and resolve them.

@mathlib-merge-conflicts mathlib-merge-conflicts Bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 14, 2026
@joelriou joelriou added the WIP Work in progress label Aug 16, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) t-category-theory Category theory tech debt Fixes cross-cutting technical debt, see the "technical debt counters" stream on zulip WIP Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant