Skip to content

[Merged by Bors] - chore: golf the proof in #26875 - #28046

Closed
grunweg wants to merge 3 commits into
leanprover-community:masterfrom
grunweg:smoothsection-mr
Closed

grunweg wants to merge 3 commits into
leanprover-community:masterfrom
grunweg:smoothsection-mr

Conversation

@grunweg

@grunweg grunweg commented Aug 6, 2025 •

Copy link
Copy Markdown
Contributor

From the path towards the existence of Riemannian metrics, i.e. towards the Levi-Civita connection.


Commits can be reviewed independently.

Open in Gitpod

@grunweg grunweg added the WIP Work in progress label Aug 6, 2025
@github-actions

github-actions Bot commented Aug 6, 2025 •

Copy link
Copy Markdown

PR summary 3c157e7927

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

- contMDiff_totalSpace_weighted_sum_of_local_sections

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-differential-geometry Manifolds etc label Aug 6, 2025
@grunweg grunweg changed the title Smoothsection mr chore: golf the proof in #26875 Aug 6, 2025
grunweg added a commit to grunweg/mathlib4 that referenced this pull request Aug 6, 2025
Extracted from leanprover-community#28046, which is necessary for the construction of Riemanian
metric. As such, part of the path towards geodesics and the Levi-Civita
connection.
@grunweg grunweg added blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) and removed WIP Work in progress labels Aug 6, 2025
@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 6, 2025
@mathlib4-merge-conflict-bot

Copy link
Copy Markdown

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions Bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 6, 2025
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Aug 20, 2025
@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 20, 2025
@mathlib4-merge-conflict-bot

Copy link
Copy Markdown

This pull request has conflicts, please merge master and resolve them.

The lemma does not really have mathematical content; most general ideas
have been factored out. Thus, I consider the brevity a net improvement.
@github-actions github-actions Bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 21, 2025
@grunweg

grunweg commented Aug 21, 2025

Copy link
Copy Markdown
Contributor Author

@michaellee94 In case you're interested, here is how I would golf the smoothness lemma you added in #26875.

@grunweg

grunweg commented Aug 21, 2025

Copy link
Copy Markdown
Contributor Author

@PatrickMassot Would you like to take a look? This is my follow-up to the PR we both reviewed.

@grunweg
grunweg requested a review from PatrickMassot August 21, 2025 13:07

@PatrickMassot PatrickMassot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Aug 22, 2025
mathlib-bors Bot pushed a commit that referenced this pull request Aug 22, 2025
From the path towards the existence of Riemannian metrics, i.e. towards the Levi-Civita connection.
@mathlib-bors

mathlib-bors Bot commented Aug 23, 2025

Copy link
Copy Markdown
Contributor

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title chore: golf the proof in #26875 [Merged by Bors] - chore: golf the proof in #26875 Aug 23, 2025
@mathlib-bors mathlib-bors Bot closed this Aug 23, 2025
Paul-Lez pushed a commit to Paul-Lez/mathlib4 that referenced this pull request Aug 23, 2025
…nity#28046)

From the path towards the existence of Riemannian metrics, i.e. towards the Levi-Civita connection.
pechersky pushed a commit to pechersky/mathlib4 that referenced this pull request Aug 25, 2025
…nity#28046)

From the path towards the existence of Riemannian metrics, i.e. towards the Levi-Civita connection.
FormulaRabbit81 pushed a commit to YaelDillies/mathlib4 that referenced this pull request Aug 30, 2025
…nity#28046)

From the path towards the existence of Riemannian metrics, i.e. towards the Levi-Civita connection.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-differential-geometry Manifolds etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants