Repository navigation
Conversation
thorimur
force-pushed
the
lint-backarrow-fix
branch
from
February 26, 2024 23:40
e485bae to
c12cf01
Compare
thorimur
changed the title
← followed by a backticklint-style.py
thorimur
force-pushed
the
lint-backarrow-fix
branch
from
February 27, 2024 02:51
214f0ef to
9b99ff1
Compare
thorimur
force-pushed
the
lint-backarrow-fix
branch
from
February 27, 2024 02:56
9b99ff1 to
5227886
Compare
2 tasks done
ghost
added
ready-to-merge
mathlib-bors Bot
pushed a commit
that referenced
this pull request
Mar 26, 2024
This PR adjusts `annotate_comments` to respect comment nesting while linting. Note that `annotate_strings` does not necessarily respect comment nesting, so this is an improvement, not a full fix. (Likewise, `annotate_comments` (still) doesn't ignore comment markers in strings.) See [Zulip](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/False.20positive.20on.20.60.E2.86.90.60.20style.20linter).
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
Bot
changed the title
lint-style.pylint-style.py
xgenereux
pushed a commit
that referenced
this pull request
Apr 15, 2024
This PR adjusts `annotate_comments` to respect comment nesting while linting. Note that `annotate_strings` does not necessarily respect comment nesting, so this is an improvement, not a full fix. (Likewise, `annotate_comments` (still) doesn't ignore comment markers in strings.) See [Zulip](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/False.20positive.20on.20.60.E2.86.90.60.20style.20linter).
atarnoam
pushed a commit
that referenced
this pull request
Apr 16, 2024
This PR adjusts `annotate_comments` to respect comment nesting while linting. Note that `annotate_strings` does not necessarily respect comment nesting, so this is an improvement, not a full fix. (Likewise, `annotate_comments` (still) doesn't ignore comment markers in strings.) See [Zulip](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/False.20positive.20on.20.60.E2.86.90.60.20style.20linter).
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
This PR adjusts `annotate_comments` to respect comment nesting while linting. Note that `annotate_strings` does not necessarily respect comment nesting, so this is an improvement, not a full fix. (Likewise, `annotate_comments` (still) doesn't ignore comment markers in strings.) See [Zulip](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/False.20positive.20on.20.60.E2.86.90.60.20style.20linter).
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
This PR adjusts `annotate_comments` to respect comment nesting while linting. Note that `annotate_strings` does not necessarily respect comment nesting, so this is an improvement, not a full fix. (Likewise, `annotate_comments` (still) doesn't ignore comment markers in strings.) See [Zulip](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/False.20positive.20on.20.60.E2.86.90.60.20style.20linter).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjusts
annotate_commentsto respect comment nesting while linting.Note that
annotate_stringsdoes not necessarily respect comment nesting, so this is an improvement, not a full fix. (Likewise,annotate_comments(still) doesn't ignore comment markers in strings.)See Zulip.
This issue appeared when the "space after "←"" linter was activated within a docstring (hence the branch name); see #10991. The latter half had been considered "not in a comment" too early due to the presence of
-/in a code block earlier in that docstring (which setin_commenttoFalse).