Repository navigation
feat(lang): format and lint Astro like Svelte - #46
Merged
Merged
Conversation
An .oxlintrc.json next to a Prettier setup marked the project as oxfmt-formatted, so Prettier stopped running on save and oxfmt took over ts files with its defaults and left astro unformatted. Only oxfmt's own config switches formatters now.
Astro files get prettier plus stylelint on format and stylelint_lsp diagnostics, the same way Svelte does. The stylelint formatter with postcss-html moves to util/stylelint.lua and serves both. The vscode-js debugger and the stylelint_lsp validate list know about astro too, and the docs now count 40 overrides.
The FAQ still said 50 extras while the code and the README have 51.
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Astro gets the same treatment Svelte already had. Upstream `lang.astro` sets only `prettier` as the formatter.
Also carries `fix(formatting): pick oxfmt only by its own config` from the same branch: the oxlint config alone no longer switches a project from prettier to oxfmt.
Test plan