Skip to content

[Bug] sanitizeCatalogImageUrl is missing from the published declaration bundle #1851

Description

@mateusslezinsky

Current Behavior

@sistent/sistent@0.22.6 exports sanitizeCatalogImageUrl at runtime, but the symbol is missing from the published dist/index.d.ts.

Because of this, importing it from the package root fails for TypeScript consumers:

import { sanitizeCatalogImageUrl } from '@sistent/sistent';
TS2305: Module '"@sistent/sistent"' has no exported member 'sanitizeCatalogImageUrl'.

This was previously addressed in #1697. The explicit root export was added in 8567da11, but was discarded by the sync merge b7d22bbc before the PR was merged.

The leaf module and the exports through Helper.ts and src/custom/index.tsx are still present. The explicit export from src/index.tsx is not.

Expected Behavior

sanitizeCatalogImageUrl should be available from the package root in both the runtime bundle and the generated TypeScript declarations.

Screenshots/Logs

Published 0.22.6 package:

npm pack @sistent/sistent@0.22.6

tar -xzOf sistent-sistent-0.22.6.tgz package/dist/index.d.ts | grep sanitizeCatalogImageUrl
# no result

tar -xzOf sistent-sistent-0.22.6.tgz package/dist/index.js | grep sanitizeCatalogImageUrl
# symbol is present

The export is present before the sync merge and absent afterward:

git show 8567da11:src/index.tsx | grep -c sanitizeCatalogImageUrl
# 3

git show 'b7d22bbc^1:src/index.tsx' | grep -c sanitizeCatalogImageUrl
# 3

git show 'b7d22bbc^2:src/index.tsx' | grep -c sanitizeCatalogImageUrl
# 0

git show b7d22bbc:src/index.tsx | grep -c sanitizeCatalogImageUrl
# 0

Environment

  • Package: @sistent/sistent@0.22.6
  • master: 731e3b4b
  • Reproduced against the published npm package

Contributor Guides and Resources

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions