Skip to content

fix: correct layout shift and resolve PDF navigation on Meet Five and Handbook cards #8087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
piyushtripathi9424 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: correct layout shift and resolve PDF navigation on Meet Five and Handbook cards #8087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
74baeed
fix: correct layout shift on Meet Five and Handbook cards
Sep 18, 2026
4d481ee
Merge branch 'master' into fix-meet-five-layout-shift
PARTH-TUSSLE Sep 27, 2026
abdadeb
fix: make pdf detection case-insensitive and handle mailto target/rel
Sep 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 42 additions & 17 deletions src/components/AdventuresVol/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,52 @@
import React from "react";
import { Link } from "gatsby";
import { HiOutlineChevronRight } from "@react-icons/all-files/hi/HiOutlineChevronRight";
import { AdventuresVolWrapper } from "./adventures-vol.style";

const AdventuresVol = ({ title, description, to, image }) => {
const isExternalOrStatic =
to &&
(to.startsWith("http://") ||
to.startsWith("https://") ||
to.split("?")[0].split("#")[0].toLowerCase().endsWith(".pdf") ||
to.startsWith("mailto:"));

const isMailTo = to && to.startsWith("mailto:");

const cardContent = (
<div className="handbook__card">
<h1 className="handbook__card--head">{title}</h1>
<div className="handbook__card--line"></div>
<img src={image} />
<p className="handbook__card--para">{description}</p>
{to && (
<div className="handbook__card--lm__container">
<span className="handbook__card--lm">
Read More <HiOutlineChevronRight />
</span>
</div>
)}
</div>
);

return (
<AdventuresVolWrapper>
<a href={to} className="handbook__card--main">
<div className="handbook__card">
<h1 className="handbook__card--head">{title}</h1>
<div className="handbook__card--line"></div>
<img src={image} />
<p className="handbook__card--para">
{description}
</p>
{to && (
<div className="handbook__card--lm__container">
<a href={to} className="handbook__card--lm">
Read More <HiOutlineChevronRight />
</a>
</div>
)}
</div>
</a>
{!to ? (
<div className="handbook__card--main">{cardContent}</div>
) : isExternalOrStatic ? (
<a
href={to}
className="handbook__card--main"
target={isMailTo ? undefined : "_blank"}
rel={isMailTo ? undefined : "noreferrer"}
>
{cardContent}
</a>
) : (
<Link to={to} className="handbook__card--main">
{cardContent}
</Link>
)}
</AdventuresVolWrapper>
);
};
Expand Down
10 changes: 4 additions & 6 deletions src/components/HandbookCard/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,18 +6,16 @@ import { HandbookCardWrapper } from "./HandbookCard.style";
const HandbookCard = ({ title, description, to }) => {
return (
<HandbookCardWrapper>
<Link to={to} class="handbook__card--main">
<Link to={to} className="handbook__card--main">
<div className="handbook__card">
<h1 className="handbook__card--head">{title}</h1>
<div className="handbook__card--line"></div>
<p className="handbook__card--para">
{description}
</p>
<p className="handbook__card--para">{description}</p>
{to && (
<div className="handbook__card--lm__container">
<a href={to} className="handbook__card--lm">
<span className="handbook__card--lm">
Read More <HiOutlineChevronRight />
</a>
</span>
</div>
)}
</div>
Expand Down
Loading